Bugzilla – Attachment 130961 Details for
Bug 30143
OAI-PMH provider may end up in an eternal loop due to missing sort
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
Bug-30143-OAI-PMH-Fix-SQL-query-used-to-fetch-dele.patch (text/plain), 921 bytes, created by
Ere Maijala
on 2022-02-21 14:10:09 UTC
(
hide
)
Description:
Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
Filename:
MIME Type:
Creator:
Ere Maijala
Created:
2022-02-21 14:10:09 UTC
Size:
921 bytes
patch
obsolete
>From 8a1edc32923d63e1a33af2e26fc305dc746b43ee Mon Sep 17 00:00:00 2001 >From: Ere Maijala <ere.maijala@helsinki.fi> >Date: Mon, 21 Feb 2022 16:07:00 +0200 >Subject: [PATCH] Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted > records > >The query was missing the "ORDER BY" and "LIMIT" clauses, which could make retrieve a wrong set of records. >--- > Koha/OAI/Server/ListBase.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/OAI/Server/ListBase.pm b/Koha/OAI/Server/ListBase.pm >index 4f1092d146..283f1b3334 100644 >--- a/Koha/OAI/Server/ListBase.pm >+++ b/Koha/OAI/Server/ListBase.pm >@@ -116,7 +116,7 @@ sub GetRecords { > $sql = " > SELECT biblionumber > FROM $table main >- WHERE $where >+ WHERE $where $order_limit > "; > > $ts_sql = "SELECT max(timestamp) FROM $table WHERE biblionumber = ?"; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30143
:
130961
|
133703
|
134352