Bugzilla – Attachment 131032 Details for
Bug 29844
Remove uses of wantarray in Koha::Objects
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29844: Fix advanced editor
Bug-29844-Fix-advanced-editor.patch (text/plain), 1.38 KB, created by
Jonathan Druart
on 2022-02-23 10:03:00 UTC
(
hide
)
Description:
Bug 29844: Fix advanced editor
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-02-23 10:03:00 UTC
Size:
1.38 KB
patch
obsolete
>From b48c466eff1ff563c6b1b220c11dc8fb78c69141 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 23 Feb 2022 11:02:24 +0100 >Subject: [PATCH] Bug 29844: Fix advanced editor > >The method Koha::Libraries->branchcode is not covered by tests! >Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Libraries=HASH(0x563bf134b810)') called at /kohadevbox/koha/svc/cataloguing/framework line 33 >--- > svc/cataloguing/framework | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/svc/cataloguing/framework b/svc/cataloguing/framework >index f7456128ad0..1014ea5de97 100755 >--- a/svc/cataloguing/framework >+++ b/svc/cataloguing/framework >@@ -30,7 +30,7 @@ foreach my $tag ( sort keys %$tagslib ) { > my $schema = Koha::Database->new->schema; > my $authorised_values = {}; > >-my $branches = { map { $_->branchcode => $_->branchname } Koha::Libraries->search_filtered }; >+my $branches = { map { $_->branchcode => $_->branchname } Koha::Libraries->search_filtered->as_list }; > $authorised_values->{branches} = []; > foreach my $thisbranch ( sort keys %$branches ) { > push @{ $authorised_values->{branches} }, { value => $thisbranch, lib => $branches->{$thisbranch} }; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29844
:
129285
|
129286
|
129287
|
129290
|
129291
|
129292
|
129293
|
129295
|
129996
|
129997
|
129998
|
129999
|
130098
|
130099
|
130100
|
130101
|
130129
|
130130
|
130131
|
130132
|
130133
|
130134
|
130135
|
130136
|
130137
|
130138
|
130139
|
130143
|
130145
|
130146
|
130481
|
130947
| 131032