From d3b3ce7d3a305640b29fc202f2d16d2df4623448 Mon Sep 17 00:00:00 2001
From: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Date: Wed, 7 Apr 2021 01:23:49 +0000
Subject: [PATCH] Bug 27631: catalogue and tags folders

Changed each of the pages in the catalogue and tags folders to have one
<h1> tag showing that describes the page, rather than the <h1>
describing the logo.

The hierarchy of heading tags may be broken in many pages, but this
will be dealt with in an additional bug.

To test:
1) Go to the Staff Client
2) Apply patch
3) Go to each of the pages in the catalogue and tags folders and check
   that they have an obvious and descriptive heading
4) Ensure that the heading in the page is <h1>

Sponsored-by: Catalyst IT

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
 .../prog/en/modules/catalogue/ISBDdetail.tt            |  8 ++++++++
 .../prog/en/modules/catalogue/MARCdetail.tt            |  1 +
 .../intranet-tmpl/prog/en/modules/catalogue/detail.tt  |  8 ++++++++
 .../prog/en/modules/catalogue/imageviewer.tt           |  2 +-
 .../prog/en/modules/catalogue/labeledMARCdetail.tt     | 10 ++++++++--
 .../prog/en/modules/catalogue/moredetail.tt            |  2 ++
 .../intranet-tmpl/prog/en/modules/catalogue/results.tt |  2 ++
 koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt   |  2 ++
 8 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
index 258879e691..00e019de88 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt
@@ -50,6 +50,14 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
+                <h1>
+                    [% IF ( unknownbiblionumber ) %]
+                        Unknown record
+                    [% ELSE %]
+                        ISBD details for [% INCLUDE 'biblio-title-head.inc' %]
+                    [% END %]
+                </h1>
+
 [% IF ( unknownbiblionumber ) %]
     <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
 [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
index f6be1b3d8f..711477dff2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
@@ -52,6 +52,7 @@
             <main>
 
 [% IF ( unknownbiblionumber ) %]
+    <h1>Unknown record</h1>
   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
 [% ELSE %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 70a22e7262..305d49b8f0 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -83,6 +83,14 @@
             <main>
                 <div class="row">
 
+                    <h1>
+                        [% IF ( unknownbiblionumber ) %]
+                            Unknown record
+                        [% ELSE %]
+                            Details for [% INCLUDE 'biblio-title-head.inc' %]
+                        [% END %]
+                    </h1>
+
 [% IF ( unknownbiblionumber ) %]
   <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
 [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
index 5e76e1e3e3..63cbeea4c4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt
@@ -53,7 +53,7 @@
 
 [% INCLUDE 'cat-toolbar.inc' %]
 
-<h3>Images for <em>[% INCLUDE 'biblio-title.inc' %]</em></h3>
+<h1>Images for <em>[% INCLUDE 'biblio-title.inc' %]</em></h1>
 <h4>[% biblio.author | html %]</h4>
 
 [% IF ( LocalCoverImages == 1 ) %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
index 2887a8c75d..4c1d4931e3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt
@@ -44,14 +44,20 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
+                <h1>
+                    [% IF ( unknownbiblionumber ) %]
+                        Unknown record
+                    [% ELSE %]
+                        Labeled MARC biblio : [% biblionumber | html %]  ( [% bibliotitle | html %] )
+                    [% END %]
+                </h1>
+
     [% IF ( unknownbiblionumber ) %]
         <div class="dialog message">The record you requested does not exist ([% biblionumber | html %]).</div>
     [% ELSE %]
 
 					[% INCLUDE 'cat-toolbar.inc' %]
 
-					[% UNLESS ( popup ) %]
-                        <h1>Labeled MARC biblio : [% biblionumber | html %]  ( [% bibliotitle | html %] )</h1>
 					[% END %]
                     <p><strong>With framework:
                     <select name="Frameworks" id="Frameworks" onchange="Changefwk(this);">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
index 745e0192d0..6db25bb690 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ -39,6 +39,8 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
+            <h1>Item details for [% INCLUDE 'biblio-title-head.inc' %]</h1>
+
 [% INCLUDE 'cat-toolbar.inc' %]
 
 <div id="catalogue_detail_biblio">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
index 59def93d62..e04fe20df8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
@@ -52,6 +52,8 @@
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
+            <h1>Search results</h1>
+
                 [% IF ( outer_sup_results_loop ) %]
                     <div class="row">
                         <div class="col-sm-8">
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
index 60946fe730..cc25b9f11d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt
@@ -37,6 +37,8 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
         <div class="col-sm-10 col-sm-push-2">
             <main>
 
+                <h1>Results for tag <em>[% tag | html %]</em></h1>
+
 [% IF ( titles ) %]
 <h3>Titles tagged with the term <em>[% tag | html %]</em></h3>
 <table id="itemst">
-- 
2.20.1