View | Details | Raw Unified | Return to bug 14367
Collapse All | Expand All

(-)a/C4/Biblio.pm (-6 / +23 lines)
Lines 87-92 use MARC::File::USMARC; Link Here
87
use MARC::File::XML;
87
use MARC::File::XML;
88
use POSIX qw( strftime );
88
use POSIX qw( strftime );
89
use Module::Load::Conditional qw( can_load );
89
use Module::Load::Conditional qw( can_load );
90
use JSON qw(encode_json decode_json);
90
91
91
use C4::Koha;
92
use C4::Koha;
92
use C4::Log qw( logaction );    # logaction
93
use C4::Log qw( logaction );    # logaction
Lines 115-120 use Koha::SearchEngine; Link Here
115
use Koha::SearchEngine::Indexer;
116
use Koha::SearchEngine::Indexer;
116
use Koha::Libraries;
117
use Koha::Libraries;
117
use Koha::Util::MARC;
118
use Koha::Util::MARC;
119
use Koha::MetadataRecord::History;
118
120
119
=head1 NAME
121
=head1 NAME
120
122
Lines 290-297 sub AddBiblio { Link Here
290
                BiblioAutoLink( $record, $frameworkcode );
292
                BiblioAutoLink( $record, $frameworkcode );
291
            }
293
            }
292
294
293
            # now add the record
295
            # now add the record (history parameter is undef: no history yet)
294
            ModBiblioMarc( $record, $biblionumber ) unless $defer_marc_save;
296
            ModBiblioMarc( $record, $biblionumber, undef ) unless $defer_marc_save;
295
297
296
            # update OAI-PMH sets
298
            # update OAI-PMH sets
297
            if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) {
299
            if(C4::Context->preference("OAI-PMH:AutoUpdateSets")) {
Lines 402-410 sub ModBiblio { Link Here
402
    # update biblionumber and biblioitemnumber in MARC
404
    # update biblionumber and biblioitemnumber in MARC
403
    # FIXME - this is assuming a 1 to 1 relationship between
405
    # FIXME - this is assuming a 1 to 1 relationship between
404
    # biblios and biblioitems
406
    # biblios and biblioitems
405
    my $sth = $dbh->prepare("select biblioitemnumber from biblioitems where biblionumber=?");
407
    my $sth = $dbh->prepare("select biblioitems.biblioitemnumber, biblio_metadata.history from biblioitems INNER JOIN biblio_metadata ON biblioitems.biblionumber = biblio_metadata.biblionumber WHERE biblioitems.biblionumber=?");
406
    $sth->execute($biblionumber);
408
    $sth->execute($biblionumber);
407
    my ($biblioitemnumber) = $sth->fetchrow;
409
    my ($biblioitemnumber, $history) = $sth->fetchrow;
408
    $sth->finish();
410
    $sth->finish();
409
    _koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );
411
    _koha_marc_update_bib_ids( $record, $frameworkcode, $biblionumber, $biblioitemnumber );
410
412
Lines 415-421 sub ModBiblio { Link Here
415
    _koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );
417
    _koha_marc_update_biblioitem_cn_sort( $record, $oldbiblio, $frameworkcode );
416
418
417
    # update the MARC record (that now contains biblio and items) with the new record data
419
    # update the MARC record (that now contains biblio and items) with the new record data
418
    ModBiblioMarc( $record, $biblionumber );
420
    ModBiblioMarc( $record, $biblionumber, $history );
419
421
420
    # modify the other koha tables
422
    # modify the other koha tables
421
    _koha_modify_biblio( $dbh, $oldbiblio, $frameworkcode );
423
    _koha_modify_biblio( $dbh, $oldbiblio, $frameworkcode );
Lines 2860-2866 Function exported, but should NOT be used, unless you really know what you're do Link Here
2860
sub ModBiblioMarc {
2862
sub ModBiblioMarc {
2861
    # pass the MARC::Record to this function, and it will create the records in
2863
    # pass the MARC::Record to this function, and it will create the records in
2862
    # the marcxml field
2864
    # the marcxml field
2863
    my ( $record, $biblionumber ) = @_;
2865
    my ( $record, $biblionumber, $history ) = @_;
2864
    if ( !$record ) {
2866
    if ( !$record ) {
2865
        carp 'ModBiblioMarc passed an undefined record';
2867
        carp 'ModBiblioMarc passed an undefined record';
2866
        return;
2868
        return;
Lines 2928-2933 sub ModBiblioMarc { Link Here
2928
    my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
2930
    my $indexer = Koha::SearchEngine::Indexer->new({ index => $Koha::SearchEngine::BIBLIOS_INDEX });
2929
    $indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );
2931
    $indexer->index_records( $biblionumber, "specialUpdate", "biblioserver" );
2930
2932
2933
    # Decode JSON history, create new record, update and re-encode to JSON.
2934
    my $historylength = 10;
2935
    eval {
2936
        $history = decode_json($history);
2937
        1;
2938
    } or do {
2939
        $history = undef;
2940
    };
2941
    my $newrecord = HistoryRecordNew($record);
2942
    my $newhistory = HistoryUpdate($newrecord, $historylength, $history);
2943
    $newhistory = encode_json($newhistory);
2944
2945
    $m_rs->update({ metadata => $record->as_xml_record($encoding), history => $newhistory });
2946
2947
    ModZebra( $biblionumber, "specialUpdate", "biblioserver", $record );
2931
    return $biblionumber;
2948
    return $biblionumber;
2932
}
2949
}
2933
2950
(-)a/Koha/MetadataRecord/History.pm (+261 lines)
Line 0 Link Here
1
package Koha::MetadataRecord::History;
2
3
# Copyright 2016 Aleisha Amohia <aleisha@catalyst.net.nz>
4
#
5
# This file is part of Koha.
6
#
7
# Koha is free software; you can redistribute it and/or modify it
8
# under the terms of the GNU General Public License as published by
9
# the Free Software Foundation; either version 3 of the License, or
10
# (at your option) any later version.
11
#
12
# Koha is distributed in the hope that it will be useful, but
13
# WITHOUT ANY WARRANTY; without even the implied warranty of
14
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15
# GNU General Public License for more details.
16
#
17
# You should have received a copy of the GNU General Public License
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
20
use strict;
21
use warnings;
22
23
use C4::Charset qw( StripNonXmlChars );
24
use JSON qw(decode_json);
25
26
use vars qw(@ISA @EXPORT);
27
28
BEGIN {
29
    require Exporter;
30
    @ISA = qw( Exporter );
31
32
    push @EXPORT, qw(
33
        &GetMarcBiblioHistory
34
        &HistoryUpdate
35
        &HistoryParse
36
        &HistoryMapUsers
37
        &HistoryBorrowerDetails
38
        &HistoryRecordNew
39
    );
40
 }
41
42
=head1 NAME
43
44
Koha::MetadataRecord::History - tracking changes to MARC records
45
46
=head1 DESCRIPTION
47
48
Koha::MetadataRecord::History not only tracks changes to MARC records and presents them in a log, but also allows users to
49
roll them back, either in batch to a previous point in the history or separately for each field (so you can roll back changes
50
to a field without changing fields that may have been changed after this one).
51
52
=head2 GetMarcBiblioHistory
53
54
    my ($record, $history) = GetMarcBiblio($biblionumber, [$embeditems]);
55
56
Returns MARC::Record representing bib identified by C<$biblionumber>.  If no bib exists, returns undef.
57
C<$biblionumber>.  If no bib exists, returns undef.
58
C<$embeditems>.  If set to true, items data are included.
59
The MARC record contains biblio data, and items data if $embeditems is set to true.
60
61
=cut
62
63
sub GetMarcBiblioHistory {
64
    my $biblionumber = shift;
65
    my $embeditems   = shift || 0;
66
    if (not defined $biblionumber) {
67
        warn "GetMarcBiblio called with undefined biblionumber";
68
        return;
69
    }
70
    my $dbh = C4::Context->dbh;
71
    my $sth = $dbh->prepare("SELECT metadata,history FROM biblio_metadata WHERE biblionumber=? ");
72
    $sth->execute($biblionumber);
73
    my $row = $sth->fetchrow_hashref;
74
    my $marcxml = StripNonXmlChars( $row->{'metadata'} );
75
    MARC::File::XML->default_record_format( C4::Context->preference('marcflavour') );
76
    my $record = MARC::Record->new();
77
    my ($history, $borrowers) = HistoryParse( $row->{'history'} );
78
    $borrowers = HistoryBorrowerDetails( $borrowers );
79
    $history = HistoryMapUsers( $history, $borrowers );
80
    if ($marcxml) {
81
        $record = eval { MARC::Record::new_from_xml( $marcxml, "utf8", C4::Context->preference('marcflavour') ) };
82
        if ($@) { warn " problem with :$biblionumber : $@ \n$marcxml"; }
83
            return unless $record;
84
            C4::Biblio::_koha_marc_update_bib_ids($record, '', $biblionumber, $biblionumber);
85
            C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems);
86
            return ($record, $history);
87
    } else {
88
        return;
89
    }
90
}
91
92
=head2 HistoryParse
93
94
Input format (JSON): [ { datetime, borrowernumber, marcxml } ]
95
Output format: { tag } { subfield } [ { borrowernumber, data, datetime } ]
96
97
=cut
98
99
sub HistoryParse {
100
    my $json = shift;
101
    if (!defined $json) {
102
        warn "HistoryParse: Missing JSON parameter";
103
        return;
104
    }
105
    my $input = decode_json($json);
106
    # Reindex the dataset; order all values by datetime under each tag name.
107
    my $borrowers = { };
108
    my $output = { };
109
    for my $item (@{$input}) {
110
        my $datetime = $item->{datetime};
111
        $borrowers->{ $item->{borrowernumber }} = undef;
112
        my $record = MARC::File::XML::decode($item->{marcxml});
113
        for my $field ($record->fields()) {
114
            my $tag = $field->tag();
115
            $output->{$tag} = {} unless defined $output->{$tag};
116
            for my $subfield ($field->subfields()) {
117
                # Build hash ref structure.
118
                my $subfield_tag = @{$subfield}[0];
119
                $output->{$tag}->{$subfield_tag} = []
120
                unless defined $output->{$tag}->{$subfield_tag};
121
                push( @{ $output->{$tag}->{$subfield_tag} }, HistoryParsedRecordNew(
122
                    @{ $subfield }[1], $item->{borrowernumber}, $datetime));
123
                }
124
            }
125
        }
126
    return ( $output, $borrowers );
127
}
128
129
=head2 HistoryBorrowerDetails
130
131
Take a hashref with borrowernumbers as keys, returns new hash with the
132
borrowernumber as key to hash containing firstname, surname and title.
133
134
=cut
135
136
sub HistoryBorrowerDetails {
137
    my $borrowernumbers = shift;
138
    my $dbh = C4::Context->dbh;
139
    my $output = { };
140
    my @numbers = keys %{$borrowernumbers};
141
    if (@numbers > 0) {
142
        # We now need to look up the numeric user id's and map to name and title strings.
143
        my $sth = $dbh->prepare(qq{SELECT
144
            borrowernumber, title, firstname, surname
145
            FROM borrowers
146
            WHERE borrowernumber IN}
147
            . '(' . join(',', ('?') x @numbers) . ')');
148
        $sth->execute(@numbers)
149
            or die ('BorrowerDetails: Unable to execute SELECT statement');
150
        while (my $row = $sth->fetchrow_hashref()) {
151
            $output->{ $row->{borrowernumber} } = { };
152
            $output->{ $row->{borrowernumber} }->{title}     = $row->{title};
153
            $output->{ $row->{borrowernumber} }->{firstname} = $row->{firstname};
154
            $output->{ $row->{borrowernumber} }->{surname}   = $row->{surname};
155
        }
156
        $sth->finish();
157
    }
158
    return $output;
159
}
160
161
=head2 HistoryMapUsers
162
163
=cut
164
165
sub HistoryMapUsers {
166
    my ($history, $borrowers) = @_;
167
    my $mappedhistory = { };
168
    for my $tag (keys %{ $history }) {
169
        $mappedhistory->{ $tag } = { };
170
        for my $field (keys %{ $history->{ $tag } }) {
171
            $mappedhistory->{ $tag }->{ $field } = [ ];
172
            for my $entry (@{ $history->{ $tag }->{ $field } }) {
173
                # C4::Dates does not allow me to print time, only dates.
174
                #my $newtime = C4::Dates->new( $history->{ $tag }->{ $field }->{ $time }->{timestamp}, 'iso' )->output('syspref');
175
                my $newitem = { };
176
                my $user = $borrowers->{ $entry->{borrowernumber} };
177
178
                # Maybe change this to work on original instead of copy?
179
                $newitem->{title}          = $user->{title};
180
                $newitem->{firstname}      = $user->{firstname};
181
                $newitem->{surname}        = $user->{surname};
182
                $newitem->{borrowernumber} = $entry->{borrowernumber};
183
                $newitem->{data}           = $entry->{data};
184
                $newitem->{datetime}       = $entry->{datetime};
185
186
                push ( @{ $mappedhistory->{ $tag }->{ $field } } , $newitem);
187
            }
188
        }
189
    }
190
    return $mappedhistory;
191
}
192
193
=head2 HistoryParsedRecordNew
194
195
=cut
196
197
sub HistoryParsedRecordNew {
198
    my ($value, $borrowernumber, $datetime) = @_;
199
    my $newrecord = {
200
        data           => $value,
201
        borrowernumber => $borrowernumber,
202
        datetime       => $datetime,
203
    };
204
    return $newrecord;
205
}
206
207
=head2 HistoryRecordNew
208
209
=cut
210
211
sub HistoryRecordNew {
212
    my ( $record ) = @_;
213
    my $encoding = C4::Context->preference("marcflavour");
214
    my $hash_record = {
215
        borrowernumber => C4::Context->userenv()->{number},
216
        datetime       => POSIX::strftime('%Y-%m-%d %T', localtime(time)),
217
        marcxml        => $record->as_xml_record($encoding),
218
    };
219
    return $hash_record;
220
}
221
222
=head2 HistoryUpdate
223
224
=cut
225
226
sub HistoryUpdate {
227
    my ( $record, $limit, $collection ) = @_;
228
    if ( !$record ) {
229
        warn "HistoryUpdate: Called with undefined record";
230
        return;
231
    }
232
    if ( ref($record) ne 'HASH' ) {
233
        warn "HistoryUpdate: Record parameter is not a hashref";
234
        return;
235
    }
236
    $limit = 10 unless defined $limit;
237
    # We need something to append history to, even if there is none.
238
    $collection = [] unless defined $collection;
239
    # Truncate history to $histsize - 1, need space for new entry.
240
    splice(@{$collection}, $limit - 1);
241
    push(@{$collection}, $record);
242
    # Sort the resulting array, newest entries first.
243
    # Removed; used to be integer timestamps. Is now MySQL date strings.
244
    #@{$collection} = sort { $a->{timestamp} < $b->{timestamp} } @{$collection};
245
    @{$collection} = sort { $a->{datetime} lt $b->{datetime} } @{$collection};
246
    return $collection;
247
}
248
249
1;
250
251
__END__
252
253
=head1 AUTHOR
254
255
Koha Development Team <http://koha-community.org/>
256
257
Paul POULAIN paul.poulain@free.fr
258
259
Joshua Ferraro jmf@liblime.com
260
261
=cut
(-)a/cataloguing/addbiblio.pl (-16 / +27 lines)
Lines 46-58 use C4::ImportBatch qw( GetImportRecordMarc ); Link Here
46
use C4::Charset qw( SetMarcUnicodeFlag );
46
use C4::Charset qw( SetMarcUnicodeFlag );
47
use Koha::BiblioFrameworks;
47
use Koha::BiblioFrameworks;
48
use Koha::DateUtils qw( dt_from_string );
48
use Koha::DateUtils qw( dt_from_string );
49
49
use C4::Koha;
50
use Koha::ItemTypes;
50
use Koha::ItemTypes;
51
use Koha::MetadataRecord::History;
51
use Koha::Libraries;
52
use Koha::Libraries;
52
53
use Koha::BiblioFrameworks;
53
use Koha::BiblioFrameworks;
54
use Koha::Patrons;
54
use Koha::Patrons;
55
56
use MARC::File::USMARC;
55
use MARC::File::USMARC;
57
use MARC::File::XML;
56
use MARC::File::XML;
58
use URI::Escape qw( uri_escape_utf8 );
57
use URI::Escape qw( uri_escape_utf8 );
Lines 284-293 sub GetMandatoryFieldZ3950 { Link Here
284
=cut
283
=cut
285
284
286
sub create_input {
285
sub create_input {
287
    my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi ) = @_;
286
    my ( $tag, $subfield, $value, $index_tag, $rec, $authorised_values_sth,$cgi, $history ) = @_;
288
    
287
    
289
    my $index_subfield = CreateKey(); # create a specifique key for each subfield
288
    my $index_subfield = CreateKey(); # create a specifique key for each subfield
290
289
290
    my $taghistory = $history->{$tag}->{$subfield};
291
292
    $value =~ s/"/&quot;/g;
293
291
    # Apply optional framework default value when it is a new record
294
    # Apply optional framework default value when it is a new record
292
    # Substitute date parts, user name
295
    # Substitute date parts, user name
293
    if ( $value eq '' && !$cgi->param('biblionumber') ) {
296
    if ( $value eq '' && !$cgi->param('biblionumber') ) {
Lines 329-334 sub create_input { Link Here
329
        value          => $value,
332
        value          => $value,
330
        maxlength      => $tagslib->{$tag}->{$subfield}->{maxlength},
333
        maxlength      => $tagslib->{$tag}->{$subfield}->{maxlength},
331
        random         => CreateKey(),
334
        random         => CreateKey(),
335
        history        => $taghistory,
332
    );
336
    );
333
337
334
    if(exists $mandatory_z3950->{$tag.$subfield}){
338
    if(exists $mandatory_z3950->{$tag.$subfield}){
Lines 387-392 sub create_input { Link Here
387
            maxlength => $subfield_data{maxlength},
391
            maxlength => $subfield_data{maxlength},
388
            readonly  => ($is_readonly) ? 1 : 0,
392
            readonly  => ($is_readonly) ? 1 : 0,
389
            authtype  => $tagslib->{$tag}->{$subfield}->{authtypecode},
393
            authtype  => $tagslib->{$tag}->{$subfield}->{authtypecode},
394
            history   => $taghistory,
390
        };
395
        };
391
396
392
    # it's a plugin field
397
    # it's a plugin field
Lines 409-414 sub create_input { Link Here
409
                javascript     => $plugin->javascript,
414
                javascript     => $plugin->javascript,
410
                plugin         => $plugin->name,
415
                plugin         => $plugin->name,
411
                noclick        => $plugin->noclick,
416
                noclick        => $plugin->noclick,
417
                history        => $taghistory,
412
            };
418
            };
413
        } else {
419
        } else {
414
            warn $plugin->errstr;
420
            warn $plugin->errstr;
Lines 421-426 sub create_input { Link Here
421
                size      => 67,
427
                size      => 67,
422
                maxlength => $subfield_data{maxlength},
428
                maxlength => $subfield_data{maxlength},
423
                readonly  => 0,
429
                readonly  => 0,
430
                history   => $taghistory,
424
            };
431
            };
425
        }
432
        }
426
433
Lines 433-438 sub create_input { Link Here
433
            value     => $value,
440
            value     => $value,
434
            size      => 67,
441
            size      => 67,
435
            maxlength => $subfield_data{maxlength},
442
            maxlength => $subfield_data{maxlength},
443
            history   => $taghistory,
436
        };
444
        };
437
445
438
    }
446
    }
Lines 453-458 sub create_input { Link Here
453
                id        => $subfield_data{id},
461
                id        => $subfield_data{id},
454
                name      => $subfield_data{id},
462
                name      => $subfield_data{id},
455
                value     => $value,
463
                value     => $value,
464
                history   => $taghistory,
456
            };
465
            };
457
466
458
        }
467
        }
Lines 465-470 sub create_input { Link Here
465
                size      => 67,
474
                size      => 67,
466
                maxlength => $subfield_data{maxlength},
475
                maxlength => $subfield_data{maxlength},
467
                readonly  => 0,
476
                readonly  => 0,
477
                history   => $taghistory,
468
            };
478
            };
469
479
470
        }
480
        }
Lines 490-500 sub format_indicator { Link Here
490
}
500
}
491
501
492
sub build_tabs {
502
sub build_tabs {
493
    my ( $template, $record, $dbh, $encoding,$input ) = @_;
503
    my ( $template, $record, $dbh, $encoding, $input, $history ) = @_;
494
504
495
    # fill arrays
505
    # fill arrays
496
    my @loop_data = ();
506
    my @loop_data = ();
497
    my $tag;
507
    #my $tag;
498
508
499
    my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
509
    my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
500
    my $query = "SELECT authorised_value, lib
510
    my $query = "SELECT authorised_value, lib
Lines 550-556 sub build_tabs { Link Here
550
		}
560
		}
551
		# loop through each field
561
		# loop through each field
552
                foreach my $field (@fields) {
562
                foreach my $field (@fields) {
553
                    
554
                    my @subfields_data;
563
                    my @subfields_data;
555
                    if ( $tag < 10 ) {
564
                    if ( $tag < 10 ) {
556
                        my ( $value, $subfield );
565
                        my ( $value, $subfield );
Lines 570-576 sub build_tabs { Link Here
570
                            @subfields_data,
579
                            @subfields_data,
571
                            &create_input(
580
                            &create_input(
572
                                $tag, $subfield, $value, $index_tag, $record,
581
                                $tag, $subfield, $value, $index_tag, $record,
573
                                $authorised_values_sth,$input
582
                                $authorised_values_sth,$input, $history
574
                            )
583
                            )
575
                        );
584
                        );
576
                    }
585
                    }
Lines 585-591 sub build_tabs { Link Here
585
                                @subfields_data,
594
                                @subfields_data,
586
                                &create_input(
595
                                &create_input(
587
                                    $tag, $subfield, $value, $index_tag,
596
                                    $tag, $subfield, $value, $index_tag,
588
                                    $record, $authorised_values_sth,$input
597
                                    $record, $authorised_values_sth,$input, $history
589
                                )
598
                                )
590
                            );
599
                            );
591
                        }
600
                        }
Lines 615-621 sub build_tabs { Link Here
615
                            @subfields_data,
624
                            @subfields_data,
616
                            &create_input(
625
                            &create_input(
617
                                $tag, $subfield, '', $index_tag, $record,
626
                                $tag, $subfield, '', $index_tag, $record,
618
                                $authorised_values_sth,$input
627
                                $authorised_values_sth,$input, $history
619
                            )
628
                            )
620
                        );
629
                        );
621
                    }
630
                    }
Lines 671-677 sub build_tabs { Link Here
671
                        @subfields_data,
680
                        @subfields_data,
672
                        &create_input(
681
                        &create_input(
673
                            $tag, $subfield->{subfield}, '', $index_tag, $record,
682
                            $tag, $subfield->{subfield}, '', $index_tag, $record,
674
                            $authorised_values_sth,$input
683
                            $authorised_values_sth,$input, $history
675
                        )
684
                        )
676
                    );
685
                    );
677
                }
686
                }
Lines 689-695 sub build_tabs { Link Here
689
                        tagfirstsubfield => $subfields_data[0],
698
                        tagfirstsubfield => $subfields_data[0],
690
                        fixedfield       => $tag < 10?1:0,
699
                        fixedfield       => $tag < 10?1:0,
691
                    );
700
                    );
692
                    
701
693
                    push @loop_data, \%tag_data ;
702
                    push @loop_data, \%tag_data ;
694
                }
703
                }
695
            }
704
            }
Lines 791-796 $mandatory_z3950 = GetMandatoryFieldZ3950($frameworkcode); Link Here
791
# -- Global
800
# -- Global
792
801
793
my $record   = -1;
802
my $record   = -1;
803
my $history  = undef;
794
my $encoding = "";
804
my $encoding = "";
795
my (
805
my (
796
	$biblionumbertagfield,
806
	$biblionumbertagfield,
Lines 801-807 my ( Link Here
801
);
811
);
802
812
803
if (($biblionumber) && !($breedingid)){
813
if (($biblionumber) && !($breedingid)){
804
    $record = GetMarcBiblio({ biblionumber => $biblionumber });
814
    ($record, $history) = GetMarcBiblioHistory($biblionumber);
805
}
815
}
806
if ($breedingid) {
816
if ($breedingid) {
807
    ( $record, $encoding ) = MARCfindbreeding( $breedingid ) ;
817
    ( $record, $encoding ) = MARCfindbreeding( $breedingid ) ;
Lines 883-889 if ( $op eq "addbiblio" ) { Link Here
883
        else {
893
        else {
884
            ( $biblionumber, $oldbibitemnum ) = AddBiblio( $record, $frameworkcode );
894
            ( $biblionumber, $oldbibitemnum ) = AddBiblio( $record, $frameworkcode );
885
        }
895
        }
886
        if ($redirect eq "items" || ($mode ne "popup" && !$is_a_modif && $redirect ne "view" && $redirect ne "just_save")){
896
        if ($redirect eq "items" || (defined $mode && $mode ne "popup" && !$is_a_modif && $redirect ne "view" && $redirect ne "just_save")){
887
	    if ($frameworkcode eq 'FA'){
897
	    if ($frameworkcode eq 'FA'){
888
		print $input->redirect(
898
		print $input->redirect(
889
            '/cgi-bin/koha/cataloguing/additem.pl?'
899
            '/cgi-bin/koha/cataloguing/additem.pl?'
Lines 942-948 if ( $op eq "addbiblio" ) { Link Here
942
        }
952
        }
943
    } else {
953
    } else {
944
    # it may be a duplicate, warn the user and do nothing
954
    # it may be a duplicate, warn the user and do nothing
945
        build_tabs ($template, $record, $dbh,$encoding,$input);
955
        build_tabs ($template, $record, $dbh,$encoding, $input, $history);
946
        $template->param(
956
        $template->param(
947
            biblionumber             => $biblionumber,
957
            biblionumber             => $biblionumber,
948
            biblioitemnumber         => $biblioitemnumber,
958
            biblioitemnumber         => $biblioitemnumber,
Lines 990-996 elsif ( $op eq "delete" ) { Link Here
990
            $record = $urecord;
1000
            $record = $urecord;
991
        };
1001
        };
992
    }
1002
    }
993
    build_tabs( $template, $record, $dbh, $encoding,$input );
1003
1004
    build_tabs( $template, $record, $dbh, $encoding, $input, $history );
994
    $template->param(
1005
    $template->param(
995
        biblionumber             => $biblionumber,
1006
        biblionumber             => $biblionumber,
996
        biblionumbertagfield        => $biblionumbertagfield,
1007
        biblionumbertagfield        => $biblionumbertagfield,
(-)a/installer/data/mysql/atomicupdate/bug_14367_-_add_history_column.perl (+9 lines)
Line 0 Link Here
1
$DBversion = 'XXX';
2
if( CheckVersion( $DBversion ) ) {
3
    unless( column_exists( 'biblio_metadata', 'history' ) ) {
4
        $dbh->do(q|ALTER TABLE biblio_metadata ADD history longtext default NULL AFTER metadata|);
5
    }
6
7
    SetVersion( $DBversion );
8
    print "Upgrade to $DBversion done (Bug 14367: Add column biblio_metadata.history)\n";
9
}
(-)a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css (+23 lines)
Lines 80-85 ul li.tag li.subfield_line.ui-sortable-helper::before { Link Here
80
	text-decoration : none;
80
	text-decoration : none;
81
}
81
}
82
82
83
.buttonHistory {
84
	font-weight : bold;
85
	text-decoration : none;
86
}
87
83
a.expandfield {
88
a.expandfield {
84
	text-decoration : none;
89
	text-decoration : none;
85
}
90
}
Lines 232-237 a.tagnum { Link Here
232
.linktools a:hover { background-color: #FFC; }
237
.linktools a:hover { background-color: #FFC; }
233
.subfield_controls { margin: 0 .5em; }
238
.subfield_controls { margin: 0 .5em; }
234
239
240
.readonly { border-width : 1px; border-style: inset; padding-left : 15px; background: #EEE url(../img/locked.png) center left no-repeat; width:29em; }
241
.subfield_history { margin : 0 .5em; float: right; }
242
235
#cataloguing_additem_itemlist {
243
#cataloguing_additem_itemlist {
236
	margin-bottom : 1em;
244
	margin-bottom : 1em;
237
}
245
}
Lines 252-257 tbody tr.active td { Link Here
252
    width: 100%;
260
    width: 100%;
253
    z-index: 1000;
261
    z-index: 1000;
254
}
262
}
263
255
#loading div {
264
#loading div {
256
    background : transparent url(../img/loading.gif) top left no-repeat;
265
    background : transparent url(../img/loading.gif) top left no-repeat;
257
    font-size : 175%;
266
    font-size : 175%;
Lines 454-456 tbody tr.active td { Link Here
454
    border-bottom: 1px solid #b9d8d9;
463
    border-bottom: 1px solid #b9d8d9;
455
    border-radius: 0;
464
    border-radius: 0;
456
}
465
}
466
467
.history_container {
468
    display: none;
469
}
470
471
.history_table {
472
    width: 100%;
473
    display: none;
474
    float: right;
475
    clear: both;
476
    font-size: 75%;
477
    width: 75%;
478
    margin: 0.3em;
479
}
(-)a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt (-3 / +52 lines)
Lines 1-6 Link Here
1
[% USE raw %]
1
[% USE raw %]
2
[% USE Asset %]
2
[% USE Asset %]
3
[% USE Koha %]
3
[% USE Koha %]
4
[% USE KohaDates %]
4
[% INCLUDE 'doc-head-open.inc' %]
5
[% INCLUDE 'doc-head-open.inc' %]
5
<title>[% IF ( biblionumber ) %]Editing [% title | html %] (Record number [% biblionumber | html %])[% ELSE %]Add MARC record[% END %] &rsaquo; Cataloging &rsaquo; Koha</title>
6
<title>[% IF ( biblionumber ) %]Editing [% title | html %] (Record number [% biblionumber | html %])[% ELSE %]Add MARC record[% END %] &rsaquo; Cataloging &rsaquo; Koha</title>
6
[% INCLUDE 'doc-head-close.inc' %]
7
[% INCLUDE 'doc-head-close.inc' %]
Lines 26-31 Link Here
26
    var Sticky;
27
    var Sticky;
27
    $(document).ready(function() {
28
    $(document).ready(function() {
28
29
30
        $(".input_marceditor").click(function(){
31
            var tag = $(this).attr('id');
32
            historyToggle(tag + '_history');
33
            return false;
34
        });
35
36
        $(".tag_editor").click(function(){
37
            var tag = $(this).attr('id');
38
            openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id, tag, 'biblio');
39
            return false;
40
        });
41
42
        $(".buttonHistory").click(function(){
43
            var tag = $(this).attr('id');
44
            HistoryToggle(tag + '_history');
45
            return false;
46
        });
47
48
        $(".hist_rollback").click(function(){
49
            var tag = $(this).attr('data-tag');
50
            var value = $(this).attr('data-history');
51
            HistoryRollback(tag, value);
52
            return false;
53
        });
54
29
        [% IF bib_doesnt_exist %]
55
        [% IF bib_doesnt_exist %]
30
            $("#addbibliotabs").hide();
56
            $("#addbibliotabs").hide();
31
            $("#toolbar").hide();
57
            $("#toolbar").hide();
Lines 1165-1180 function PopupMARCFieldDoc(field) { Link Here
1165
                                                <div class="subfield_controls">
1191
                                                <div class="subfield_controls">
1166
                                                    [% IF ( mv.type == 'text' ) %]
1192
                                                    [% IF ( mv.type == 'text' ) %]
1167
                                                        [% IF ( mv.authtype ) %]
1193
                                                        [% IF ( mv.authtype ) %]
1168
                                                            <a href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype | html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a>
1194
                                                            <a id="[%- mv.authtype | html %]" href="#" class="buttonDot tag_editor" onclick="openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'[%- mv.authtype | html -%]','biblio'); return false;" tabindex="1" title="Tag editor">Tag editor</a>
1169
                                                        [% END %]
1195
                                                        [% END %]
1170
                                                    [% ELSIF ( mv.type == 'text_complex' ) %]
1196
                                                    [% ELSIF ( mv.type == 'text_complex' ) %]
1171
                                                            [% IF mv.noclick %]
1197
                                                            [% IF mv.noclick %]
1172
                                                                <span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>
1198
                                                                <span class="buttonDot tag_editor disabled" tabindex="-1" title="Field autofilled by plugin"></span>
1173
                                                            [% ELSE %]
1199
                                                            [% ELSE %]
1174
                                                                [% IF mv.plugin == "upload.pl" %]
1200
                                                                [% IF mv.plugin == "upload.pl" %]
1175
                                                                    <a href="#" id="buttonDot_[% mv.id | html %]" class="tag_editor upload framework_plugin" tabindex="1"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>
1201
                                                                    <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor upload framework_plugin" tabindex="2"><i class="fa fa-upload" aria-hidden="true"></i> Upload</a>
1176
                                                                [% ELSE %]
1202
                                                                [% ELSE %]
1177
                                                                    <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="1" title="Tag editor">Tag editor</a>
1203
                                                                    <a href="#" id="buttonDot_[% mv.id | html %]" class="buttonDot tag_editor framework_plugin" tabindex="2" title="Tag editor">Tag editor</a>
1178
                                                                [% END %]
1204
                                                                [% END %]
1179
                                                            [% END %]
1205
                                                            [% END %]
1180
                                                        </span>
1206
                                                        </span>
Lines 1188-1193 function PopupMARCFieldDoc(field) { Link Here
1188
                                                        </a>
1214
                                                        </a>
1189
                                                    [% END %]
1215
                                                    [% END %]
1190
                                                </div>
1216
                                                </div>
1217
1218
                                                [% IF ( subfield_loo.history ) %]
1219
                                                <span class="subfield_history">
1220
                                                    <a href="#" class="buttonHistory" id="[%- mv.id | html -%]">
1221
                                                        <img src="[% interface | html %]/[% theme | html %]/img/icon-history.png" alt="History" title="Display history for this field" />
1222
                                                    </a>
1223
                                                </span>
1224
1225
                                                <table class="history_table" id="[%- mv.id | html -%]_history" name="[%- mv.name | html -%]_history">
1226
                                                    <tr>
1227
                                                        <th>Value</th>
1228
                                                        <th>Date</th>
1229
                                                        <th>User</th>
1230
                                                    </tr>
1231
                                                    [% FOREACH hist IN subfield_loo.history %]
1232
                                                    <tr>
1233
                                                        <td><a href="#" data-tag='[%- mv.id | html -%]' data-history='[% hist.data | html %]' class='hist_rollback'>[% hist.data | html %]</a></td>
1234
                                                        <td>[% hist.datetime | $KohaDates with_hours = 1 %]</td>
1235
                                                        <td>[% hist.title | html %] [% hist.firstname | html %] [% hist.surname | html %]</td>
1236
                                                    </tr>
1237
                                                    [% END %]
1238
                                                </table>
1239
                                                [% END %]
1191
                                            </li> <!-- /.subfield_line -->
1240
                                            </li> <!-- /.subfield_line -->
1192
                                            <!-- End of the line -->
1241
                                            <!-- End of the line -->
1193
                                        [% END # /FOREACH subfield_loop %]
1242
                                        [% END # /FOREACH subfield_loop %]
(-)a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js (+10 lines)
Lines 58-63 function openAuth(tagsubfieldid,authtype,source) { Link Here
58
    window.open("../authorities/auth_finder.pl?source="+source+"&authtypecode="+authtype+"&index="+tagsubfieldid+"&value_mainstr="+encodeURIComponent(mainmainstring)+"&value_main="+encodeURIComponent(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes');
58
    window.open("../authorities/auth_finder.pl?source="+source+"&authtypecode="+authtype+"&index="+tagsubfieldid+"&value_mainstr="+encodeURIComponent(mainmainstring)+"&value_main="+encodeURIComponent(mainstring), "_blank",'width=700,height=550,toolbar=false,scrollbars=yes');
59
}
59
}
60
60
61
function HistoryToggle (tagid)
62
{
63
	$('#' + tagid).toggle();
64
}
65
66
function HistoryRollback (tagid, value)
67
{
68
	$('#' + tagid).val(value);
69
}
70
61
function ExpandField(index) {
71
function ExpandField(index) {
62
    var original = document.getElementById(index); //original <li>
72
    var original = document.getElementById(index); //original <li>
63
    var lis = original.getElementsByTagName('li');
73
    var lis = original.getElementsByTagName('li');
(-)a/t/db_dependent/BiblioHistory.t (-1 / +256 lines)
Line 0 Link Here
0
- 
1
#!/usr/bin/perl
2
3
use Modern::Perl;
4
use t::lib::TestBuilder;
5
use t::lib::Mocks;
6
use Test::More tests => 6;
7
use POSIX qw(strftime);
8
9
use MARC::Record;
10
use MARC::Field;
11
use JSON qw(encode_json);
12
13
use Koha::MetadataRecord::History;
14
15
BEGIN {
16
    use_ok('C4::Biblio');
17
}
18
19
our $dbh = C4::Context->dbh;
20
$dbh->{AutoCommit} = 0;
21
$dbh->{RaiseError} = 0;
22
23
$dbh->do(q|DELETE FROM issues|);
24
$dbh->do(q|DELETE FROM items|);
25
$dbh->do(q|DELETE FROM borrowers|);
26
$dbh->do(q|DELETE FROM branches|);
27
$dbh->do(q|DELETE FROM categories|);
28
$dbh->do(q|DELETE FROM biblioitems|);
29
30
my $builder = t::lib::TestBuilder->new();
31
32
my $branch = $builder->build(
33
    {
34
        source => 'Branch',
35
    }
36
);
37
38
my $category = $builder->build(
39
    {
40
        source => 'Category',
41
    }
42
);
43
44
my $patron1 = $builder->build(
45
    {
46
        source => 'Borrower',
47
        value  => {
48
            title        => 'Mr/Mrs',
49
            firstname    => 'First name',
50
            surname      => 'Surname',
51
            categorycode => $category->{categorycode},
52
            branchcode   => $branch->{branchcode},
53
        },
54
    }
55
);
56
57
my $patron2 = $builder->build(
58
    {
59
        source => 'Borrower',
60
        value  => {
61
            title        => 'Mr/Mrs 2',
62
            firstname    => 'First name 2',
63
            surname      => 'Surname 2',
64
            categorycode => $category->{categorycode},
65
            branchcode   => $branch->{branchcode},
66
        },
67
    }
68
);
69
70
my $biblio = $builder->build(
71
    {
72
        source => 'Biblio',
73
        value  => {
74
            branchcode => $branch->{branchcode},
75
        },
76
    }
77
);
78
79
C4::Context->_new_userenv('DUMMY_SESSION_ID');
80
C4::Context->set_userenv( $patron1->{borrowernumber},
81
    $patron1->{userid}, 'usercnum', $patron1->{firstname}, $patron1->{surname},
82
    $branch->{branchcode}, 'My library', 0 );
83
84
# Item with no pre-existing history backlog.
85
my $record1 = MARC::Record->new();
86
my $field1  = MARC::Field->new(
87
    245, '1', '0',
88
    'a' => 'First Title',
89
    'c' => 'Some dude'
90
);
91
$record1->append_fields($field1);
92
93
my $record2 = MARC::Record->new();
94
my $field2  = MARC::Field->new(
95
    245, '1', '0',
96
    'a' => 'Second Title',
97
    'c' => 'Former dude'
98
);
99
$record2->append_fields($field2);
100
101
my $biblioitem1 = $builder->build(
102
    {
103
        source => 'Biblioitem',
104
        value  => {
105
            marcxml => $record1->as_xml(),
106
            history => undef,
107
        }
108
    }
109
);
110
111
# items{tagname}{subfield}{timestamp}{borrowernumber|timestamp|marcxml}
112
my $items = [
113
    {
114
        borrowernumber => $patron1->{borrowernumber},
115
        datetime       => '2012-08-12 12:00:10',
116
        marcxml        => $record1->as_xml(),
117
    },
118
    {
119
        borrowernumber => $patron2->{borrowernumber},
120
        datetime       => '2012-08-12 12:00:10',
121
        marcxml        => $record2->as_xml(),
122
    }
123
];
124
125
# Item with previous history entries.
126
my $biblioitem2 = $builder->build(
127
    {
128
        source => 'Biblioitem',
129
        value  => {
130
            marcxml => $record2->as_xml(),
131
            history => encode_json($items),
132
        }
133
    }
134
);
135
136
my $expected_history = {
137
    245 => {
138
        a => [
139
            {
140
                borrowernumber => $patron1->{borrowernumber},
141
                data           => 'First Title',
142
                datetime       => '2012-08-12 12:00:10'
143
            },
144
            {
145
                borrowernumber => $patron2->{borrowernumber},
146
                data           => 'Second Title',
147
                datetime       => '2012-08-12 12:00:10'
148
            },
149
        ],
150
        c => [
151
            {
152
                borrowernumber => $patron1->{borrowernumber},
153
                data           => 'Some dude',
154
                datetime       => '2012-08-12 12:00:10'
155
            },
156
            {
157
                borrowernumber => $patron2->{borrowernumber},
158
                data           => 'Former dude',
159
                datetime       => '2012-08-12 12:00:10'
160
            },
161
        ],
162
    },
163
};
164
165
my $expected_users = {
166
    $patron1->{borrowernumber} => undef,
167
    $patron2->{borrowernumber} => undef,
168
};
169
170
# Tests the decoding and reindexing of the data, without any borrower
171
# information implanted into the history itself.
172
173
my ( $history, $users ) = C4::Biblio::HistoryParse( encode_json($items) );
174
175
is_deeply( $history, $expected_history, 'HistoryParse: Output' );
176
is_deeply( $users,   $expected_users,   'HistoryParse: Users' );
177
178
# Tests the extraction of full borrower details based on the borrowernumber.
179
my $expected_details = {
180
    $patron1->{borrowernumber} => {
181
        firstname => $patron1->{firstname},
182
        surname   => $patron1->{surname},
183
        title     => $patron1->{title},
184
    },
185
    $patron2->{borrowernumber} => {
186
        firstname => $patron2->{firstname},
187
        surname   => $patron2->{surname},
188
        title     => $patron2->{title},
189
    }
190
};
191
192
my $details = HistoryBorrowerDetails($expected_users);
193
is_deeply( $details, $expected_details, 'HistoryBorrowerDetails: Output' );
194
195
{
196
    my $expected_mapped_history = {
197
        245 => {
198
            a => [
199
                {
200
                    borrowernumber => $patron1->{borrowernumber},
201
                    data           => 'First Title',
202
                    firstname      => $patron1->{firstname},
203
                    surname        => $patron1->{surname},
204
                    title          => $patron1->{title},
205
                    datetime       => '2012-08-12 12:00:10'
206
                },
207
                {
208
                    borrowernumber => $patron2->{borrowernumber},
209
                    data           => 'Second Title',
210
                    firstname      => $patron2->{firstname},
211
                    surname        => $patron2->{surname},
212
                    title          => $patron2->{title},
213
                    datetime       => '2012-08-12 12:00:10'
214
                },
215
            ],
216
            c => [
217
                {
218
                    borrowernumber => $patron1->{borrowernumber},
219
                    data           => 'Some dude',
220
                    firstname      => $patron1->{firstname},
221
                    surname        => $patron1->{surname},
222
                    title          => $patron1->{title},
223
                    datetime       => '2012-08-12 12:00:10'
224
                },
225
                {
226
                    borrowernumber => $patron2->{borrowernumber},
227
                    data           => 'Former dude',
228
                    firstname      => $patron2->{firstname},
229
                    surname        => $patron2->{surname},
230
                    title          => $patron2->{title},
231
                    datetime       => '2012-08-12 12:00:10'
232
                },
233
            ]
234
        }
235
    };
236
237
    $history = C4::Biblio::HistoryMapUsers( $expected_history, $details );
238
239
    is_deeply( $history, $expected_mapped_history, 'HistoryMapUsers: Output' );
240
241
  #my $record;
242
  #( $record, $history ) = GetMarcBiblioHistory( $biblioitem2->{biblionumber} );
243
244
    #is_deeply( $record, $record2 );
245
    #is_deeply( $history, $expected_mapped_history );
246
}
247
248
# The C4::Context will provide the expected user borrowernumber.
249
my $record = HistoryRecordNew($record1);
250
251
my $expected_record = {
252
    borrowernumber => C4::Context->userenv()->{number},
253
    marcxml        => $record1->as_xml_record(),
254
    datetime       => POSIX::strftime( '%Y-%m-%d %T', localtime ),
255
};
256
is_deeply( $record, $expected_record );

Return to bug 14367