Bugzilla – Attachment 131288 Details for
Bug 29857
We must stringify our exceptions correctly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29857: (follow-up) Fix t/db_dependent/Koha/Plugins/Plugins.t
Bug-29857-follow-up-Fix-tdbdependentKohaPluginsPlu.patch (text/plain), 1.95 KB, created by
Fridolin Somers
on 2022-03-02 18:09:15 UTC
(
hide
)
Description:
Bug 29857: (follow-up) Fix t/db_dependent/Koha/Plugins/Plugins.t
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2022-03-02 18:09:15 UTC
Size:
1.95 KB
patch
obsolete
>From 6ccf04661a23c57e36875267fdec068c3346c49e Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 2 Mar 2022 07:57:58 -1000 >Subject: [PATCH] Bug 29857: (follow-up) Fix > t/db_dependent/Koha/Plugins/Plugins.t > >--- > t/db_dependent/Koha/Plugins/Plugins.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/Koha/Plugins/Plugins.t b/t/db_dependent/Koha/Plugins/Plugins.t >index 14990ad09a..0360a8ab87 100755 >--- a/t/db_dependent/Koha/Plugins/Plugins.t >+++ b/t/db_dependent/Koha/Plugins/Plugins.t >@@ -108,15 +108,15 @@ subtest 'more call() tests' => sub { > my $bc = 1; > warnings_are > { Koha::Plugins->call('item_barcode_transform', \$bc); } >- [ 'Plugin error (Test Plugin): item_barcode_transform called with parameter: 1', >- 'Plugin error (Test Plugin for item_barcode_transform): item_barcode_transform called with parameter: 2' ]; >+ [ qq{Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: 1'\n}, >+ qq{Plugin error (Test Plugin for item_barcode_transform): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: 2'\n} ]; > is( $bc, 8, "Got expected response" ); > > my $cn = 'abcd'; > warnings_are > { Koha::Plugins->call('item_barcode_transform', \$bc); } >- [ 'Plugin error (Test Plugin): item_barcode_transform called with parameter: 8', >- 'Plugin error (Test Plugin for item_barcode_transform): item_barcode_transform called with parameter: 16' ]; >+ [ qq{Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: 8'\n}, >+ qq{Plugin error (Test Plugin for item_barcode_transform): Exception 'Koha::Exception' thrown 'item_barcode_transform called with parameter: 16'\n} ]; > is( $cn, 'abcd', "Got expected response" ); > > t::lib::Mocks::mock_config('enable_plugins', 0); >-- >2.35.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29857
:
129329
|
129330
|
130007
|
130008
|
130009
|
130010
|
130011
|
130012
|
130013
|
130014
|
130015
|
130156
|
130157
|
130158
|
130355
|
131112
|
131113
|
131114
|
131115
|
131116
|
131117
|
131232
|
131240
|
131241
|
131242
|
131243
|
131244
|
131256
|
131258
|
131287
| 131288 |
131289
|
131290
|
131291