From e330a6153327ff65c34d16dae5bce28f43fa2efa Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Wed, 30 Sep 2020 11:51:22 +0200
Subject: [PATCH] Bug 26311: (follow-up) loop through the patron with date of
 birth and in categories having age limits

Also added category limits in message, for example (12-18)

Check patron :
- with no date of birth
- with invalid age in category having age required
- with invalid age in category having upper age limit
- with invalid age in category having age required and upper age limit
---
 .../search_for_data_inconsistencies.pl        | 30 +++++++++++++++----
 1 file changed, 24 insertions(+), 6 deletions(-)

diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
index 046d72bd36..4676d1d15b 100755
--- a/misc/maintenance/search_for_data_inconsistencies.pl
+++ b/misc/maintenance/search_for_data_inconsistencies.pl
@@ -229,16 +229,34 @@ use C4::Biblio qw( GetMarcFromKohaField );
 }
 
 {
-    my $patrons = Koha::Patrons->search( {}, { order_by => [ 'categorycode', 'borrowernumber' ] } );
+    my $aging_patrons = Koha::Patrons->search(
+        {
+            -not => {
+                -or => {
+                    'me.dateofbirth' => undef,
+                    -and => {
+                        'categorycode.dateofbirthrequired' => undef,
+                        'categorycode.upperagelimit'       => undef,
+                    }
+                }
+            }
+        },
+        { prefetch => ['categorycode'] },
+        { order_by => [ 'me.categorycode', 'me.borrowernumber' ] },
+    );
     my @invalid_patrons;
-    while ( my $patron = $patrons->next ) {
-        push @invalid_patrons, $patron unless $patron->is_valid_age;
+    while ( my $aging_patron = $aging_patrons->next ) {
+        push @invalid_patrons, $aging_patron unless $aging_patron->is_valid_age;
     }
     if (@invalid_patrons) {
         new_section("Patrons with invalid age for category");
-        foreach my $patron (@invalid_patrons) {
-            new_item( sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s'",
-                $patron->borrowernumber, $patron->get_age, $patron->category->categorycode, );
+        foreach my $invalid_patron (@invalid_patrons) {
+            my $category = $invalid_patron->category;
+            new_item(
+                sprintf "Patron borrowernumber=%s has an invalid age of %s for their category '%s' (%s-%s)",
+                $invalid_patron->borrowernumber, $invalid_patron->get_age, $category->categorycode,
+                $category->dateofbirthrequired,  $category->upperagelimit
+            );
         }
         new_hint("You may change the patron's category automatically with misc/cronjobs/update_patrons_category.pl");
     }
-- 
2.35.1