From 5a6dec09d5cc3ae5b3c0bff9a778c94b4a65d44c Mon Sep 17 00:00:00 2001
From: Andrew Nugged <nugged@gmail.com>
Date: Thu, 9 Dec 2021 15:07:07 +0200
Subject: [PATCH] Bug 20447: (QA follow-up) Warning suppression

tab might be undefined

(sidenote: probably tags->subfields->tabs structures should be defined
more)

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 cataloguing/addholding.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cataloguing/addholding.pl b/cataloguing/addholding.pl
index 55ea3eef8c..c78c11a4a4 100755
--- a/cataloguing/addholding.pl
+++ b/cataloguing/addholding.pl
@@ -455,7 +455,8 @@ sub build_tabs {
                     foreach my $subfield ( keys %{ $tagslib->{$tag} } )
                     {
                         next if ( length $subfield != 1 );
-                        next if ( $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
+                        next if ( defined $tagslib->{$tag}->{$subfield}->{tab} and
+                            $tagslib->{$tag}->{$subfield}->{tab} ne $tabloop );
                         next if ( $tag < 10 );
                         next
                           if ( ( $tagslib->{$tag}->{$subfield}->{hidden} <= -4 )
-- 
2.30.2