Bugzilla – Attachment 13159 Details for
Bug 9002
Remove Problematic Logic from Patron Messaging Preferences Form
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form
0001-Bug-9002-Remove-Problematic-Logic-from-Patron-Messag.patch (text/plain), 1.93 KB, created by
David Cook
on 2012-10-31 21:23:29 UTC
(
hide
)
Description:
Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form
Filename:
MIME Type:
Creator:
David Cook
Created:
2012-10-31 21:23:29 UTC
Size:
1.93 KB
patch
obsolete
>From 045e7a31c99bfe65f12901c902a9196871c7d65d Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 1 Nov 2012 08:17:08 +1100 >Subject: [PATCH] Bug 9002 - Remove Problematic Logic from Patron Messaging > Preferences Form >Content-Type: text/plain; charset="utf-8" > >If you do not have SMSSendDriver set and you do not have a message_transport_type of "sms", you will get an extra table column filled with a hyphen "-" and no corresponding table heading in the Patron Messaging Preferences table. > >This pushes the table out of alignment so the email checkbox goes under "Digests Only?", the digests checkbox goes under "Do not notify", and the Do not notify checkbox is pushed to the side with no heading. > >--- > >While this doesn't affect new installs, it might affect upgrades, unless the upgrade scripts insert message_transport_type preferences. > >--- > >In any case, it's a couple lines of useless code. It makes more sense to use the same logic as TalkingTechItivaPhone. >--- > .../prog/en/includes/messaging-preference-form.inc | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >index b08c5ca..ed6b067 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc >@@ -52,7 +52,7 @@ > [% ELSE %] > <td>-</td> > [% END %] >- [% IF ( messaging_preference.transport_sms ) %] >+ > [% IF ( SMSSendDriver ) %]<td> > [% IF ( messaging_form_inactive ) %] > [% IF ( messaging_preference.transports_sms ) %] >@@ -80,9 +80,6 @@ > [% END %] > [% END %] > </td>[% END %] >- [% ELSE %] >- <td>-</td> >- [% END %] > > [% IF ( TalkingTechItivaPhone ) %]<td> > [% IF ( messaging_form_inactive ) %] >-- >1.7.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9002
:
13159
|
13301
|
13302
|
16226
|
17062