From 23db308bbe53d437f49f25647b1489d3aad07483 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 14 Mar 2022 17:05:56 +0000 Subject: [PATCH] Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed --- koha-tmpl/intranet-tmpl/prog/js/catalog.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/catalog.js b/koha-tmpl/intranet-tmpl/prog/js/catalog.js index 2d63aecb81..7b40873f20 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/catalog.js +++ b/koha-tmpl/intranet-tmpl/prog/js/catalog.js @@ -124,8 +124,7 @@ $(document).ready(function() { $("#deletebiblio").tooltip(); $("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled") .on("click",function(e){ - e.preventDefault(); - alertNoItems(); + e.stopPropagation(); }) .tooltip(); -- 2.30.2