View | Details | Raw Unified | Return to bug 20256
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Patrons.t (-1 / +74 lines)
Lines 2343-2349 subtest 'filter_by_amount_owed' => sub { Link Here
2343
    is( $filtered->_resultset->as_subselect_rs->count, 1,
2343
    is( $filtered->_resultset->as_subselect_rs->count, 1,
2344
"filter_by_amount_owed({ more_than => 6.00, library => $library2->{branchcode} }) found one patron"
2344
"filter_by_amount_owed({ more_than => 6.00, library => $library2->{branchcode} }) found one patron"
2345
    );
2345
    );
2346
};
2347
2348
subtest 'libraries_where_can_edit_items + can_edit_item' => sub {
2349
    plan tests => 2;
2350
2351
    $schema->storage->txn_begin;
2352
    my $dbh = $schema->storage->dbh;
2353
2354
    $dbh->do("DELETE FROM library_groups");
2355
2356
    # group1
2357
    #   library_1A
2358
    #   library_1B
2359
    # group2
2360
    #   library_2A
2361
    my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_limit_item_editing => 1 } )->store;
2362
    my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_limit_item_editing => 1 } )->store;
2363
    my $library_1A = $builder->build( { source => 'Branch' } );
2364
    my $library_1B = $builder->build( { source => 'Branch' } );
2365
    my $library_2A = $builder->build( { source => 'Branch' } );
2366
    $library_1A = Koha::Libraries->find( $library_1A->{branchcode} );
2367
    $library_1B = Koha::Libraries->find( $library_1B->{branchcode} );
2368
    $library_2A = Koha::Libraries->find( $library_2A->{branchcode} );
2369
    Koha::Library::Group->new( { branchcode => $library_1A->branchcode, parent_id => $group_1->id } )->store;
2370
    Koha::Library::Group->new( { branchcode => $library_1B->branchcode, parent_id => $group_1->id } )->store;
2371
    Koha::Library::Group->new( { branchcode => $library_2A->branchcode, parent_id => $group_2->id } )->store;
2372
2373
    my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 9, ?)|); # 9 for editcatalogue
2374
    # 2 patrons from library_1A (group1)
2375
    # patron_1A_1 see patron's infos from outside its group
2376
    # Setting flags => undef to not be considered as superlibrarian
2377
    my $patron_1A_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2378
    $patron_1A_1 = Koha::Patrons->find( $patron_1A_1->{borrowernumber} );
2379
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_items' );
2380
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_any_item' );
2381
    # patron_1A_2 can only see patron's info from its group
2382
    my $patron_1A_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2383
    $patron_1A_2 = Koha::Patrons->find( $patron_1A_2->{borrowernumber} );
2384
    $sth->execute( $patron_1A_2->borrowernumber, 'edit_items' );
2385
    # 1 patron from library_1B (group1)
2386
    my $patron_1B = $builder->build({ source => 'Borrower', value => { branchcode => $library_1B->branchcode, flags => undef, }});
2387
    $patron_1B = Koha::Patrons->find( $patron_1B->{borrowernumber} );
2388
    # 1 patron from library_2A (group2) can only see patron's info from its group
2389
    my $patron_2A = $builder->build({ source => 'Borrower', value => { branchcode => $library_2A->branchcode, flags => undef, }});
2390
    $patron_2A = Koha::Patrons->find( $patron_2A->{borrowernumber} );
2391
    $sth->execute( $patron_2A->borrowernumber, 'edit_items' );
2392
2393
    subtest 'libraries_where_can_edit_items' => sub {
2394
        plan tests => 3;
2346
2395
2396
        my @branchcodes;
2397
2398
        @branchcodes = $patron_1A_1->libraries_where_can_edit_items;
2399
        is_deeply( \@branchcodes, [], "patron_1A_1 has edit_any_item => No restrictions" );
2400
2401
        @branchcodes = $patron_1A_2->libraries_where_can_edit_items;
2402
        is_deeply( \@branchcodes, [ sort ( $library_1A->branchcode, $library_1B->branchcode ) ], "patron_1A_2 doesn't have edit_any_item => Can only edit items from its group" );
2403
2404
        @branchcodes = $patron_2A->libraries_where_can_edit_items;
2405
        is_deeply( \@branchcodes, [$library_2A->branchcode], "patron_2A doesn't have edit_any_item => Can only see patron's from its group" );
2406
    };
2407
2408
    subtest 'can_edit_item' => sub {
2409
        plan tests => 6;
2410
2411
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_1 });
2412
        is( $patron_1A_1->can_edit_item( $library_1A->id ), 1, "patron_1A_1 can see patron_1A_2, from its library" );
2413
        is( $patron_1A_1->can_edit_item( $library_1B->id ),   1, "patron_1A_1 can see patron_1B, from its group" );
2414
        is( $patron_1A_1->can_edit_item( $library_2A->id ),   1, "patron_1A_1 can see patron_1A_2, from another group" );
2415
2416
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_2 });
2417
        is( $patron_1A_2->can_edit_item( $library_1A->id ),   1, "patron_1A_2 can see patron_1A_1, from its library" );
2418
        is( $patron_1A_2->can_edit_item( $library_1B->id ),   1, "patron_1A_2 can see patron_1B, from its group" );
2419
        is( $patron_1A_2->can_edit_item( $library_2A->id ),   0, "patron_1A_2 can NOT see patron_2A, from another group" );
2420
    };
2347
};
2421
};
2348
2422
2349
$schema->storage->txn_rollback;
2423
$schema->storage->txn_rollback;
2350
- 

Return to bug 20256