View | Details | Raw Unified | Return to bug 14364
Collapse All | Expand All

(-)a/C4/Reserves.pm (-1 / +48 lines)
Lines 1188-1199 sub ModReserveAffect { Link Here
1188
        $hold->set_processing();
1188
        $hold->set_processing();
1189
    } else {
1189
    } else {
1190
        $hold->set_waiting($desk_id);
1190
        $hold->set_waiting($desk_id);
1191
        _koha_notify_reserve( $hold->reserve_id, $notify_library ) unless $already_on_shelf;
1191
        _koha_notify_reserve( $hold->reserve_id ) unless $already_on_shelf;
1192
        # Complete transfer if one exists
1192
        # Complete transfer if one exists
1193
        my $transfer = $hold->item->get_transfer;
1193
        my $transfer = $hold->item->get_transfer;
1194
        $transfer->receive if $transfer;
1194
        $transfer->receive if $transfer;
1195
    }
1195
    }
1196
1196
1197
    _koha_notify_hold_changed( $hold ) if $notify_library;
1198
1197
    _FixPriority( { biblionumber => $biblionumber } );
1199
    _FixPriority( { biblionumber => $biblionumber } );
1198
    my $item = Koha::Items->find($itemnumber);
1200
    my $item = Koha::Items->find($itemnumber);
1199
    if ( $item->location && $item->location eq 'CART'
1201
    if ( $item->location && $item->location eq 'CART'
Lines 1915-1920 sub _koha_notify_reserve { Link Here
1915
    }
1917
    }
1916
}
1918
}
1917
1919
1920
=head2 _koha_notify_hold_changed
1921
1922
  _koha_notify_hold_changed( $hold_object );
1923
1924
=cut
1925
1926
sub _koha_notify_hold_changed {
1927
    my $hold = shift;
1928
1929
    my $patron = $hold->patron;
1930
    my $library = $hold->branch;
1931
1932
    my $letter = C4::Letters::GetPreparedLetter(
1933
        module      => 'reserves',
1934
        letter_code => 'HOLD_CHANGED',
1935
        branchcode  => $hold->branchcode,
1936
        substitute  => { today => output_pref( dt_from_string ) },
1937
        tables      => {
1938
            'branches'    => $library->unblessed,
1939
            'borrowers'   => $patron->unblessed,
1940
            'biblio'      => $hold->biblionumber,
1941
            'biblioitems' => $hold->biblionumber,
1942
            'reserves'    => $hold->unblessed,
1943
            'items'       => $hold->itemnumber,
1944
        },
1945
    );
1946
1947
    return unless $letter;
1948
1949
    my $email =
1950
         C4::Context->preference('ExpireReservesAutoFillEmail')
1951
      || $library->branchemail
1952
      || C4::Context->preference('KohaAdminEmailAddress');
1953
1954
    C4::Letters::EnqueueLetter(
1955
        {
1956
            letter                 => $letter,
1957
            borrowernumber         => $patron->id,
1958
            message_transport_type => 'email',
1959
            from_address           => $email,
1960
            to_address             => $email,
1961
        }
1962
    );
1963
}
1964
1918
=head2 _ShiftPriorityByDateAndPriority
1965
=head2 _ShiftPriorityByDateAndPriority
1919
1966
1920
  $new_priority = _ShiftPriorityByDateAndPriority( $biblionumber, $reservedate, $priority );
1967
  $new_priority = _ShiftPriorityByDateAndPriority( $biblionumber, $reservedate, $priority );
(-)a/t/db_dependent/Holds/ExpireReservesAutoFill.t (-9 / +8 lines)
Lines 100-110 subtest 'Test automatically canceled expired waiting holds to fill the next hold Link Here
100
100
101
    CancelExpiredReserves();
101
    CancelExpiredReserves();
102
102
103
    my @holds = Koha::Holds->search( {}, { order_by => 'priority' } );
103
    my $holds = Koha::Holds->search( {}, { order_by => 'priority' } );
104
    $hold_2 = $holds[0];
104
    $hold_2 = $holds->next;
105
    $hold_3 = $holds[1];
105
    $hold_3 = $holds->next;
106
106
107
    is( @holds,            2,   'Found 2 holds' );
107
    is( $holds->count,     2,   'Found 2 holds' );
108
    is( $hold_2->priority, 0,   'Next hold in line now has priority of 0' );
108
    is( $hold_2->priority, 0,   'Next hold in line now has priority of 0' );
109
    is( $hold_2->found,    'W', 'Next hold in line is now set to waiting' );
109
    is( $hold_2->found,    'W', 'Next hold in line is now set to waiting' );
110
110
Lines 117-126 subtest 'Test automatically canceled expired waiting holds to fill the next hold Link Here
117
117
118
    CancelExpiredReserves();
118
    CancelExpiredReserves();
119
119
120
    @holds = Koha::Holds->search( {}, { order_by => 'priority' } );
120
    $holds = Koha::Holds->search( {}, { order_by => 'priority' } );
121
    $hold_3 = $holds[0];
121
    $hold_3 = $holds->next;
122
122
123
    is( @holds,            1,   'Found 1 hold' );
123
    is( $holds->count,     1,   'Found 1 hold' );
124
    is( $hold_3->priority, 0,   'Next hold in line now has priority of 0' );
124
    is( $hold_3->priority, 0,   'Next hold in line now has priority of 0' );
125
    is( $hold_3->found,    'W', 'Next hold in line is now set to waiting' );
125
    is( $hold_3->found,    'W', 'Next hold in line is now set to waiting' );
126
126
Lines 186-190 subtest 'Test automatically canceled expired waiting holds to fill the next hold Link Here
186
186
187
    my @messages = $schema->resultset('MessageQueue')
187
    my @messages = $schema->resultset('MessageQueue')
188
      ->search( { letter_code => 'HOLD_CHANGED' } );
188
      ->search( { letter_code => 'HOLD_CHANGED' } );
189
    is( @messages, 0, 'No messages in the message queue when generating transfer' );
189
    is( @messages, 1, 'Nessage is generated in the message queue when generating transfer' );
190
};
190
};
191
- 

Return to bug 14364