View | Details | Raw Unified | Return to bug 30110
Collapse All | Expand All

(-)a/C4/Circulation.pm (-1 / +1 lines)
Lines 892-898 sub CanBookBeIssued { Link Here
892
    my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
892
    my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
893
    $no_issues_charge_guarantors = undef unless looks_like_number( $no_issues_charge_guarantors );
893
    $no_issues_charge_guarantors = undef unless looks_like_number( $no_issues_charge_guarantors );
894
    if ( defined $no_issues_charge_guarantors ) {
894
    if ( defined $no_issues_charge_guarantors ) {
895
        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
895
        my $guarantors_non_issues_charges = $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
896
896
897
        if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors && !$inprocess && !$allowfineoverride) {
897
        if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors && !$inprocess && !$allowfineoverride) {
898
            $issuingimpossible{DEBT_GUARANTORS} = $guarantors_non_issues_charges;
898
            $issuingimpossible{DEBT_GUARANTORS} = $guarantors_non_issues_charges;
(-)a/C4/Search.pm (-1 / +1 lines)
Lines 889-895 sub _build_weighted_query { Link Here
889
    my $fuzzy_enabled = C4::Context->preference("QueryFuzzy")        || 0;
889
    my $fuzzy_enabled = C4::Context->preference("QueryFuzzy")        || 0;
890
    $operand =~ s/"/ /g;    # Bug 7518: searches with quotation marks don't work
890
    $operand =~ s/"/ /g;    # Bug 7518: searches with quotation marks don't work
891
891
892
    my $weighted_query .= "(rk=(";    # Specifies that we're applying rank
892
    my $weighted_query = "(rk=(";    # Specifies that we're applying rank
893
893
894
    # Keyword, or, no index specified
894
    # Keyword, or, no index specified
895
    if ( ( $index eq 'kw' ) || ( !$index ) ) {
895
    if ( ( $index eq 'kw' ) || ( !$index ) ) {
(-)a/C4/Utils/DataTables/VirtualShelves.pm (-1 / +1 lines)
Lines 44-50 sub search { Link Here
44
    my @args;
44
    my @args;
45
    # private
45
    # private
46
    if ( !$public ) {
46
    if ( !$public ) {
47
        my $join_vs .= q|
47
        my $join_vs = q|
48
            LEFT JOIN virtualshelfshares sh ON sh.shelfnumber = vs.shelfnumber
48
            LEFT JOIN virtualshelfshares sh ON sh.shelfnumber = vs.shelfnumber
49
            AND sh.borrowernumber = ?
49
            AND sh.borrowernumber = ?
50
        |;
50
        |;
(-)a/Koha/DateUtils.pm (-1 / +1 lines)
Lines 143-149 sub dt_from_string { Link Here
143
    }
143
    }
144
144
145
    # Add the facultative time part including time zone offset; ISO8601 allows +02 or +0200 too
145
    # Add the facultative time part including time zone offset; ISO8601 allows +02 or +0200 too
146
    my $time_re .= qr{
146
    my $time_re = qr{
147
            (
147
            (
148
                [Tt]?
148
                [Tt]?
149
                \s*
149
                \s*
(-)a/circ/circulation.pl (-1 / +1 lines)
Lines 494-500 if ( $patron ) { Link Here
494
    # Check the debt of this patrons guarantors *and* the guarantees of those guarantors
494
    # Check the debt of this patrons guarantors *and* the guarantees of those guarantors
495
    my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
495
    my $no_issues_charge_guarantors = C4::Context->preference("NoIssuesChargeGuarantorsWithGuarantees");
496
    if ( $no_issues_charge_guarantors ) {
496
    if ( $no_issues_charge_guarantors ) {
497
        my $guarantors_non_issues_charges += $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
497
        my $guarantors_non_issues_charges = $patron->relationships_debt({ include_guarantors => 1, only_this_guarantor => 0, include_this_patron => 1 });
498
498
499
        if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors ) {
499
        if ( $guarantors_non_issues_charges > $no_issues_charge_guarantors ) {
500
            $template->param(
500
            $template->param(
(-)a/t/Labels_split_ccn.t (-1 / +1 lines)
Lines 38-44 BEGIN { Link Here
38
    }
38
    }
39
    my $test_num = 1;
39
    my $test_num = 1;
40
    foreach (keys(%$ccns)) {
40
    foreach (keys(%$ccns)) {
41
        my $split_num += scalar(@{$ccns->{$_}});
41
        my $split_num = scalar(@{$ccns->{$_}});
42
        $test_num += 2 * $split_num;
42
        $test_num += 2 * $split_num;
43
        $test_num += 4;
43
        $test_num += 4;
44
    }
44
    }
(-)a/t/Labels_split_ddcn.t (-1 / +1 lines)
Lines 37-43 BEGIN { Link Here
37
    }
37
    }
38
    my $test_num = 1;
38
    my $test_num = 1;
39
    foreach (keys(%$ddcns)) {
39
    foreach (keys(%$ddcns)) {
40
        my $split_num += scalar(@{$ddcns->{$_}});
40
        my $split_num = scalar(@{$ddcns->{$_}});
41
        $test_num += 2 * $split_num;
41
        $test_num += 2 * $split_num;
42
        $test_num += 4;
42
        $test_num += 4;
43
    }
43
    }
(-)a/t/Labels_split_lccn.t (-1 / +1 lines)
Lines 40-46 BEGIN { Link Here
40
    }
40
    }
41
    my $test_num = 1;
41
    my $test_num = 1;
42
    foreach (keys(%$lccns)) {
42
    foreach (keys(%$lccns)) {
43
        my $split_num += scalar(@{$lccns->{$_}});
43
        my $split_num = scalar(@{$lccns->{$_}});
44
        $test_num += 2 * $split_num;
44
        $test_num += 2 * $split_num;
45
        $test_num += 4;
45
        $test_num += 4;
46
    }
46
    }
(-)a/t/db_dependent/SIP/Message.t (-3 / +2 lines)
Lines 124-130 subtest 'hold_patron_name() tests' => sub { Link Here
124
124
125
    is( $sip_item->hold_patron_name, q{}, "SIP item with no hold returns empty string for patron name" );
125
    is( $sip_item->hold_patron_name, q{}, "SIP item with no hold returns empty string for patron name" );
126
126
127
    my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_name, $server );
127
    my $resp = C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_name, $server );
128
    is( $resp, q{}, "maybe_add returns empty string for SIP item with no hold returns empty string" );
128
    is( $resp, q{}, "maybe_add returns empty string for SIP item with no hold returns empty string" );
129
129
130
    $schema->storage->txn_rollback;
130
    $schema->storage->txn_rollback;
Lines 837-843 sub test_hold_patron_bcode { Link Here
837
837
838
    is( $sip_item->hold_patron_bcode, q{}, "SIP item with no hold returns empty string" );
838
    is( $sip_item->hold_patron_bcode, q{}, "SIP item with no hold returns empty string" );
839
839
840
    my $resp .= C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_bcode, $server );
840
    my $resp = C4::SIP::Sip::maybe_add( FID_CALL_NUMBER, $sip_item->hold_patron_bcode, $server );
841
    is( $resp, q{}, "maybe_add returns empty string for SIP item with no hold returns empty string" );
841
    is( $resp, q{}, "maybe_add returns empty string for SIP item with no hold returns empty string" );
842
}
842
}
843
843
844
- 

Return to bug 30110