From 0c5dc32087f0bb3f64b92db6a320aaa8c5be047e Mon Sep 17 00:00:00 2001 From: Janusz Kaczmarek Date: Tue, 8 Mar 2022 22:42:44 +0100 Subject: [PATCH] Bug 30251: (bug 10902 follow-up) With IndependentBranches non-superlibrarians do not get autocomplete list in circulation module Having IndependentBranches on, a librarian who is not superlibrarian does not get a autocomplete hint list when entering a part of the patron's name (while performing check out, etc.) Koha registers an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous at .../Koha/Objects.pm line 312 This is due to fix to the bug 10902 -- addig "prefetch => 'branchcode'" to the attributes of the query in circ/ysearch.pl, while having branchcode in the search parameters. Test plan: ---------- 1. Have IndependentBranches on, PatronAutoComplete set to 'Try. Be a librarian without superlibrarian privileges. Have some patrons defined. 2. In the main input field on the top, with Check out active, try to put 3+ characters from the known user name/cardnumber etc. You will get no hint. 3. Apply the patch. 4. Repeat 2. You should now see an autocomplete hint list. Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize --- circ/ysearch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/ysearch.pl b/circ/ysearch.pl index efe1a62d24..3f2650cbeb 100755 --- a/circ/ysearch.pl +++ b/circ/ysearch.pl @@ -66,7 +66,7 @@ foreach my $p (@parts) { ); } -push( @params, { branchcode => C4::Context->userenv->{branch} } ) if $limit_on_branch; +push( @params, { 'me.branchcode' => C4::Context->userenv->{branch} } ) if $limit_on_branch; my $borrowers_rs = Koha::Patrons->search_limited( { -and => \@params }, -- 2.20.1