From 3a2bc4f5434f962523208737cd6fb2f85e4d4e34 Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Tue, 15 Feb 2022 11:33:33 -0500 Subject: [PATCH] Bug 30114: Koha offline circulation will always cancel the next hold when issuing item to a patron If a record has holds on it, and, using offline circulation, an item on that is checked out to a patron that did not have a hold on the record, the next hold that would have trapped that item will be canceled. 1) Place two bib level holds on an item for two patrons 2) Find a third patron, note his or her cardnumber 3) Create the file test.koc by copying and pasting the following into a text editor Version=1.0 Generator=kocTest GeneratorVersion=0.7 2008-06-11 12:24:11 547 issue PATRONCARDNUMBER ITEMBARCODE note the fields are tab delemited, ensure the tabs do not get lost when copying and pasting! 4) Upload the offline circ action, and commit the action 5) Note the item was checked out to the third patron 6) Note one of the other patron's holds were canceled 7) Reset your database 8) Apply this patch 9) Test again, no hold should be canceled! Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 965e02ca6c..43e20633f1 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -4053,7 +4053,7 @@ sub ProcessOfflineIssue { $patron->unblessed, $operation->{'barcode'}, undef, - 1, + undef, $operation->{timestamp}, undef, ); -- 2.20.1