Bugzilla – Attachment 132209 Details for
Bug 30222
Auto_renew_digest still sends every day when renewals are not allowed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30222: Remove warning
Bug-30222-Remove-warning.patch (text/plain), 1.49 KB, created by
Jonathan Druart
on 2022-03-25 08:16:25 UTC
(
hide
)
Description:
Bug 30222: Remove warning
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-03-25 08:16:25 UTC
Size:
1.49 KB
patch
obsolete
>From 32e05988fce6cdae4689a554b7063955063d0065 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 25 Mar 2022 09:05:18 +0100 >Subject: [PATCH] Bug 30222: Remove warning > >Use of uninitialized value in string ne at misc/cronjobs/automatic_renewals.pl line 193. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > misc/cronjobs/automatic_renewals.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index ecd3c24f504..a80c166ee01 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -190,8 +190,8 @@ while ( my $auto_renew = $auto_renews->next ) { > say sprintf "Issue id: %s for borrower: %s and item: %s %s not be renewed. (%s)", > $auto_renew->issue_id, $auto_renew->borrowernumber, $auto_renew->itemnumber, $confirm ? 'will' : 'would', $error; > } >- $updated = 1 if ($error ne $auto_renew->auto_renew_error); >- if ( not $auto_renew->auto_renew_error or $updated ) { >+ $updated = 1 if (!$auto_renew->auto_renew_error || $error ne $auto_renew->auto_renew_error); >+ if ( $updated ) { > $auto_renew->auto_renew_error($error)->store if $confirm; > push @{ $report{ $auto_renew->borrowernumber } }, $auto_renew > if $error ne 'auto_too_soon' && ( $wants_email && !$wants_digest ); # Do not notify if it's too soon >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30222
:
131586
|
131587
|
131659
|
131660
|
131662
|
131663
|
131721
|
131728
|
131729
|
131730
|
132205
|
132206
|
132207
|
132208
| 132209