From 36c07f831b9f96f4054df02794e45164afe16271 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 2 Feb 2022 10:39:19 +0000 Subject: [PATCH] Bug 28294: Remove unit tests for updateWrongTransfer Content-Type: text/plain; charset=utf-8 --- t/db_dependent/Circulation.t | 44 ++---------------------------------- 1 file changed, 2 insertions(+), 42 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 7cd2c0d74f..a041b5a34c 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -18,7 +18,7 @@ use Modern::Perl; use utf8; -use Test::More tests => 60; +use Test::More tests => 59; use Test::Exception; use Test::MockModule; use Test::Deep qw( cmp_deeply ); @@ -33,7 +33,7 @@ use t::lib::TestBuilder; use C4::Accounts; use C4::Calendar qw( new insert_single_holiday insert_week_day_holiday delete_holiday ); -use C4::Circulation qw( AddIssue AddReturn CanBookBeRenewed GetIssuingCharges AddRenewal GetSoonestRenewDate GetLatestAutoRenewDate LostItem GetUpcomingDueIssues CanBookBeIssued AddIssuingCharge MarkIssueReturned ProcessOfflinePayment transferbook updateWrongTransfer ); +use C4::Circulation qw( AddIssue AddReturn CanBookBeRenewed GetIssuingCharges AddRenewal GetSoonestRenewDate GetLatestAutoRenewDate LostItem GetUpcomingDueIssues CanBookBeIssued AddIssuingCharge MarkIssueReturned ProcessOfflinePayment transferbook ); use C4::Biblio; use C4::Items qw( ModItemTransfer ); use C4::Log; @@ -5114,46 +5114,6 @@ subtest "Item's onloan value should be set if checked out item is checked out to ok( $item->get_from_storage->onloan, "Item's onloan column is set after second checkout" ); }; -subtest "updateWrongTransfer tests" => sub { - plan tests => 5; - - my $library1 = $builder->build_object( { class => 'Koha::Libraries' } ); - my $library2 = $builder->build_object( { class => 'Koha::Libraries' } ); - my $library3 = $builder->build_object( { class => 'Koha::Libraries' } ); - my $item = $builder->build_sample_item( - { - homebranch => $library1->branchcode, - holdingbranch => $library2->branchcode, - datelastseen => undef - } - ); - - my $transfer = $builder->build_object( - { - class => 'Koha::Item::Transfers', - value => { - itemnumber => $item->itemnumber, - frombranch => $library2->branchcode, - tobranch => $library1->branchcode, - daterequested => dt_from_string, - datesent => dt_from_string, - datecancelled => undef, - datearrived => undef, - reason => 'Manual' - } - } - ); - is( ref($transfer), 'Koha::Item::Transfer', 'Mock transfer added' ); - - my $new_transfer = C4::Circulation::updateWrongTransfer($item->itemnumber, $library1->branchcode); - is(ref($new_transfer), 'Koha::Item::Transfer', "updateWrongTransfer returns a 'Koha::Item::Transfer' object"); - ok( !$new_transfer->in_transit, "New transfer is NOT created as in transit (or cancelled)"); - - my $original_transfer = $transfer->get_from_storage; - ok( defined($original_transfer->datecancelled), "Original transfer was cancelled"); - is( $original_transfer->cancellation_reason, 'WrongTransfer', "Original transfer cancellation reason is 'WrongTransfer'"); -}; - subtest "SendCirculationAlert" => sub { plan tests => 2; -- 2.20.1