Bugzilla – Attachment 132331 Details for
Bug 30107
When editing a desk, the currently logged in library is selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30107: When editing desks default to the branch the desk belongs to
Bug-30107-When-editing-desks-default-to-the-branch.patch (text/plain), 2.55 KB, created by
Séverine Queune
on 2022-03-28 13:43:46 UTC
(
hide
)
Description:
Bug 30107: When editing desks default to the branch the desk belongs to
Filename:
MIME Type:
Creator:
Séverine Queune
Created:
2022-03-28 13:43:46 UTC
Size:
2.55 KB
patch
obsolete
>From c201cb668b4f137e9e9d4dea6a4b55b46a736e62 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 9 Mar 2022 18:41:56 +0000 >Subject: [PATCH] Bug 30107: When editing desks default to the branch the desk > belongs to >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >TO test: >1. Turn on UseCirculationDesks >2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. >3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch >4. Apply patch >5. Try editing desk again, now the dropdown should default the library that the desk belongs to. >6. Try making a new desk and make sure it defaults to the logged in branch > >Signed-off-by: Séverine Queune <severine.queune@bulac.fr> >--- > .../intranet-tmpl/prog/en/modules/admin/desks.tt | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >index 2043f68603..a1cb6437be 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt >@@ -118,10 +118,15 @@ > <select id="branchcode" name="branchcode" required="required"> > <option value=""></option> > [% FOREACH branch IN branches %] >- [% IF (Branches.GetLoggedInBranchcode == branch.branchcode) %] >- <option value="[% branch.branchcode|html %]" selected="selected">[% branch.branchname|html %]</option> >+ [% IF desk %] >+ [% IF (desk.branchcode == branch.branchcode) %] >+ <option value="[% branch.branchcode|html %]" selected="selected">[% branch.branchname|html %]</option> >+ [% END%] > [% ELSE %] >- <option value="[% branch.branchcode|html %]">[% branch.branchname|html %]</option> >+ [% IF (Branches.GetLoggedInBranchcode == branch.branchcode) %] >+ <option value="[% branch.branchcode|html %]" selected="selected">[% branch.branchname|html %]</option> >+ [% END%] >+ <option value="[% branch.branchcode|html %]">[% branch.branchname|html %]</option> > [% END %] > [% END %] > </select> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30107
:
130699
|
131529
|
132331
|
132371