Bugzilla – Attachment 132904 Details for
Bug 27631
Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27631: (follow-up) Modify logo CSS to give better alignment
Bug-27631-follow-up-Modify-logo-CSS-to-give-better.patch (text/plain), 3.23 KB, created by
Katrin Fischer
on 2022-04-02 22:05:44 UTC
(
hide
)
Description:
Bug 27631: (follow-up) Modify logo CSS to give better alignment
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-04-02 22:05:44 UTC
Size:
3.23 KB
patch
obsolete
>From c63b853d69b2db7738179100aafb1a075ed7cb71 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 8 Nov 2021 12:57:41 +0000 >Subject: [PATCH] Bug 27631: (follow-up) Modify logo CSS to give better > alignment > >This patch modifies the CSS of the Koha logo and its container so that >it more closely matches the previous version and so that alignment is >handled better at various browser widths. > >To test, apply the patch and build the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). > >Check various pages in the staff interface to confirm that the position >of the Koha logo is correct. Adjust your browser width to confirm that >the alignment adapts at narrow widths. > >Test also on pages where the header search form can be expanded, e.g. >Patrons -> [+] to expand search options. Or Acquisitions -> Orders >search -> [+]. Confirm that logo alignment is correct on these pages >too. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../prog/css/src/staff-global.scss | 62 ++++++++----------- > 1 file changed, 26 insertions(+), 36 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index 714ad42e00..83ae99cae6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -334,22 +334,26 @@ form { > h1 { > font-size: 161.6%; > font-weight: bold; >- >- &#logo { >- border: 0 none; >- float: left; >- margin: .75em .3em .75em .7em; >- padding: 0; >- width: 180px; >- } > } > > #logo { >- border: 0 none; >- float: left; >- margin: .75em .3em .75em .7em; >- padding: 0; >- width: 180px; >+ background: transparent url("../img/koha-logo-medium.png") no-repeat 50% 50%; >+ border: 0 none; >+ margin: 2rem 1rem; >+ padding: 0; >+ width: 180px; >+ >+ a { >+ border: 0; >+ cursor: pointer; >+ display: block; >+ height: 0 !important; >+ margin: 0; >+ overflow: hidden; >+ padding: 44px 0 0; >+ text-decoration: none; >+ width: 180px; >+ } > } > > h2 { >@@ -628,8 +632,8 @@ ol { > > .gradient { > background-image: linear-gradient(to bottom, rgb(230, 240, 242) 1%, rgb(255, 255, 255) 99%); >- display: inline-block; >- width: 100%; >+ align-items: flex-start; >+ display: flex; > } > > .cart-controls { >@@ -2020,24 +2024,6 @@ i { > } > } > >- >-#logo { >- background: transparent url("../img/koha-logo-medium.png") no-repeat scroll 0%; >- margin: .75em .3em .75em .7em; >- >- a { >- border: 0; >- cursor: pointer; >- display: block; >- height: 0 !important; >- margin: 0; >- overflow: hidden; >- padding: 44px 0 0; >- text-decoration: none; >- width: 180px; >- } >-} >- > #closewindow { > margin-top: 2em; > text-align: center; >@@ -4734,9 +4720,13 @@ div .suggestion_note { > } > } > >- div#logo { >- float: none; >- margin: auto; >+ .gradient { >+ align-items: center; >+ flex-direction: column; >+ } >+ >+ #logo { >+ margin: 1rem; > } > > #marcPreview { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27631
:
116352
|
119492
|
119493
|
119496
|
119497
|
119498
|
119500
|
119501
|
119502
|
119544
|
119545
|
119546
|
119547
|
119830
|
119831
|
119832
|
119834
|
119835
|
119836
|
119837
|
119838
|
119839
|
119840
|
119841
|
119842
|
119843
|
120158
|
120159
|
120160
|
120161
|
120162
|
120166
|
120190
|
120191
|
121356
|
121469
|
121470
|
121522
|
121559
|
125547
|
125548
|
125549
|
125550
|
125551
|
125552
|
125553
|
125554
|
125555
|
125556
|
125557
|
125558
|
125559
|
125560
|
125561
|
125562
|
125563
|
125564
|
127295
|
127296
|
127297
|
127298
|
127299
|
127300
|
127301
|
127302
|
127303
|
127304
|
127305
|
127306
|
127307
|
127308
|
127309
|
127310
|
127311
|
127312
|
127432
|
127433
|
127449
|
127456
|
131069
|
131070
|
131071
|
131072
|
131073
|
131074
|
131075
|
131076
|
131077
|
131078
|
131079
|
131080
|
131081
|
131082
|
131083
|
131084
|
131085
|
131086
|
131087
|
131192
|
132886
|
132887
|
132888
|
132889
|
132890
|
132891
|
132892
|
132893
|
132894
|
132895
|
132896
|
132897
|
132898
|
132899
|
132900
|
132901
|
132902
|
132903
| 132904 |
132905