Bugzilla – Attachment 132905 Details for
Bug 27631
Accessibility: Staff interface - `h1` on each page is Logo but should be page description/title
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27631: (follow-up) Various corrections
Bug-27631-follow-up-Various-corrections.patch (text/plain), 10.71 KB, created by
Katrin Fischer
on 2022-04-02 22:05:50 UTC
(
hide
)
Description:
Bug 27631: (follow-up) Various corrections
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2022-04-02 22:05:50 UTC
Size:
10.71 KB
patch
obsolete
>From 9bfe41cf2165a20f56ac781c4fb17646547a133c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 1 Mar 2022 15:22:55 +0000 >Subject: [PATCH] Bug 27631: (follow-up) Various corrections > >This patch addresses issues found during QA: > >- Double headings (patron details page) >- Inconsistent heading position (check out, patron accounting) >- Missing headings when there is no data (Library EANs, Item search > fields, MARC modification templates). >- Typo: Z19.50 => Z39.50 >- Reword "Classification sources" heading: "Classification > configuration" > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > .../intranet-tmpl/prog/en/modules/admin/admin-home.tt | 2 +- > .../intranet-tmpl/prog/en/modules/admin/classsources.tt | 2 +- > .../prog/en/modules/admin/edi_ean_accounts.tt | 2 +- > .../prog/en/modules/admin/items_search_fields.tt | 1 + > .../intranet-tmpl/prog/en/modules/admin/z3950servers.tt | 2 +- > .../intranet-tmpl/prog/en/modules/circ/circulation.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/members/housebound.tt | 3 +-- > .../intranet-tmpl/prog/en/modules/members/mancredit.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/members/maninvoice.tt | 3 ++- > .../intranet-tmpl/prog/en/modules/members/moremember.tt | 7 ------- > koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 4 ++-- > .../prog/en/modules/tools/marc_modification_templates.tt | 1 + > 12 files changed, 15 insertions(+), 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >index 6ec128e569..d592a1bc58 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt >@@ -173,7 +173,7 @@ > <dd>Create and manage Authorities frameworks that define the characteristics of your MARC Records (field and subfield definitions)</dd> > [% END %] > [% IF ( CAN_user_parameters_manage_classifications ) %] >- <dt><a href="/cgi-bin/koha/admin/classsources.pl">Classification sources</a></dt> >+ <dt><a href="/cgi-bin/koha/admin/classsources.pl">Classification configuration</a></dt> > <dd>Define classification sources (i.e. call number schemes) used by your collection. Also define filing rules used for sorting call numbers and splitting rules for splitting them</dd> > [% END %] > [% IF ( CAN_user_parameters_manage_matching_rules ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >index d1970ec646..d7e6e9a59a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt >@@ -340,7 +340,7 @@ Classification sources › Administration › Koha > <a class="btn btn-default" id="newrule" href="[% script_name | url %]?op=add_sort_rule"><i class="fa fa-plus"></i> New filing rule</a> > <a class="btn btn-default" id="newrule" href="[% script_name | url %]?op=add_split_rule"><i class="fa fa-plus"></i> New splitting rule</a> > </div> >-<h1>Classification sources</h1> >+<h1>Classification configuration</h1> > <h2>Classification sources</h2> > <table> > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt >index 0b1630ba69..53e94fa47f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt >@@ -158,8 +158,8 @@ Library EANs › Administration › Koha > [% END %] > > [% IF display %] >-[% IF ( eans ) %] > <h1>Library EANs</h1> >+[% IF ( eans ) %] > <table> > <tr> > <th>Library</th> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt >index 1c12fa62bf..e8e089c7de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt >@@ -97,6 +97,7 @@ > </table> > </div> > [% ELSE %] >+ <h1>Item search fields</h1> > <div class="dialog message"> > There are no item search fields defined. > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >index 2341282c2a..25c4bce99f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt >@@ -207,7 +207,7 @@ > <a id="newserver" class="btn btn-default" href="/cgi-bin/koha/admin/z3950servers.pl?op=add&type=zed"><i class="fa fa-plus"></i> New Z39.50 server</a> > <a id="newserver" class="btn btn-default" href="/cgi-bin/koha/admin/z3950servers.pl?op=add&type=sru"><i class="fa fa-plus"></i> New SRU server</a> > </div> >- <h1>Z19.50/SRU servers administration</h1> >+ <h1>Z39.50/SRU servers administration</h1> > [% IF id %] > You searched for record [% id | html %] > [% ELSIF searchfield %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 8b75efa880..6e899e2ef6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -60,12 +60,12 @@ > <div class="row"> > <div class="col-sm-10 col-sm-push-2"> > >- <h1>Checkouts</h1> >- > [% IF patron %] > [% INCLUDE 'members-toolbar.inc' %] > [% END %] > >+ <h1>Checkouts</h1> >+ > <!-- INITIAL BLOC : PARAMETERS & BORROWER INFO --> > [% IF ( was_renewed ) %] > <div class="dialog message">Patron's account has been renewed until [% expiry | $KohaDates %]</div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >index a744cb279a..40c074ecfa 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >@@ -115,7 +115,6 @@ > > <!-- Create or edit housebound_profile --> > [% IF ( method == 'update_or_create' ) %] >- <h4>Manage housebound profile</h4> > <form id="editform" method="post" name="editform" > action="/cgi-bin/koha/members/housebound.pl"> > <input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" /> >@@ -125,7 +124,7 @@ > <input type="hidden" name="method" value="createconfirm" /> > [% END %] > <fieldset id="houseboundentry" class="rows"> >- <legend>Housebound details</legend> >+ <legend>Manage housebound profile</legend> > <ol> > <li> > <label for="day" class="required">Delivery day:</label> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt >index d0e17266d8..9052257697 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt >@@ -36,10 +36,10 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >- <h1>Manual credit</h1> >- > [% INCLUDE 'members-toolbar.inc' %] > >+ <h1>Manual credit</h1> >+ > <!-- The manual invoice and credit buttons --> > <div class="statictabs"> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt >index df050d8595..8d41ea71a8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/maninvoice.tt >@@ -37,10 +37,11 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >- <h1>Manual invoice</h1> > > [% INCLUDE 'members-toolbar.inc' %] > >+ <h1>Manual invoice</h1> >+ > <!-- The manual invoice and credit buttons --> > <div class="statictabs"> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >index bc88503dd1..7b6c3a4504 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt >@@ -85,13 +85,6 @@ > > <div class="row"> > >- <h3> >- [% UNLESS ( I ) %] >- [% patron.title | html %] [% patron.firstname | html %] >- [% END %] >- [% patron.surname | html %] ([% patron.cardnumber | html %]) >- </h3> >- > [% IF ( was_renewed ) %] > <div class="dialog message"> > Patron's account has been renewed until [% patron.dateexpiry | $KohaDates %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >index 3e8838f59f..3f29a4078e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt >@@ -38,10 +38,10 @@ > <div class="col-sm-10 col-sm-push-2"> > <main> > >- <h1>Make a payment</h1> >- > [% INCLUDE 'members-toolbar.inc' borrowernumber=patron.borrowernumber %] > >+<h1>Make a payment</h1> >+ > <!-- The manual invoice and credit buttons --> > <div class="statictabs"> > <ul> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >index 880ffc12c0..2c0222b80f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt >@@ -300,6 +300,7 @@ > [% END %] > > [% ELSE %] >+ <h1>MARC modification templates</h1> > <div class="dialog message"><p>There are no defined templates. Please create a template first.</p></div> > [% END # /IF TemplatesLoop %] > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27631
:
116352
|
119492
|
119493
|
119496
|
119497
|
119498
|
119500
|
119501
|
119502
|
119544
|
119545
|
119546
|
119547
|
119830
|
119831
|
119832
|
119834
|
119835
|
119836
|
119837
|
119838
|
119839
|
119840
|
119841
|
119842
|
119843
|
120158
|
120159
|
120160
|
120161
|
120162
|
120166
|
120190
|
120191
|
121356
|
121469
|
121470
|
121522
|
121559
|
125547
|
125548
|
125549
|
125550
|
125551
|
125552
|
125553
|
125554
|
125555
|
125556
|
125557
|
125558
|
125559
|
125560
|
125561
|
125562
|
125563
|
125564
|
127295
|
127296
|
127297
|
127298
|
127299
|
127300
|
127301
|
127302
|
127303
|
127304
|
127305
|
127306
|
127307
|
127308
|
127309
|
127310
|
127311
|
127312
|
127432
|
127433
|
127449
|
127456
|
131069
|
131070
|
131071
|
131072
|
131073
|
131074
|
131075
|
131076
|
131077
|
131078
|
131079
|
131080
|
131081
|
131082
|
131083
|
131084
|
131085
|
131086
|
131087
|
131192
|
132886
|
132887
|
132888
|
132889
|
132890
|
132891
|
132892
|
132893
|
132894
|
132895
|
132896
|
132897
|
132898
|
132899
|
132900
|
132901
|
132902
|
132903
|
132904
| 132905