Bugzilla – Attachment 132967 Details for
Bug 30456
Convert checkout history tabs to Bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30456: Convert checkout history tabs to Bootstrap
Bug-30456-Convert-checkout-history-tabs-to-Bootstr.patch (text/plain), 3.82 KB, created by
Owen Leonard
on 2022-04-05 12:47:50 UTC
(
hide
)
Description:
Bug 30456: Convert checkout history tabs to Bootstrap
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-04-05 12:47:50 UTC
Size:
3.82 KB
patch
obsolete
>From 91a886a82ccd85bde30ca3562410b2d48eb98995 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 5 Apr 2022 12:35:33 +0000 >Subject: [PATCH] Bug 30456: Convert checkout history tabs to Bootstrap > >This patch updates the circulation history page to replace jQueryUI tabs >with Bootstrap tabs. A minor JavaScript change is required to work >with the new HTML structure. > >To test you'll view the staff interface circulation history page with >the OnSiteCheckouts system preference on and off. > >- With OnSiteCheckouts off, locate a patron who has current and/or > past checkouts. >- View the "Circulation history" page for that patron. >- The table of checkouts should display with no tabbed interface. > >- With OnSiteCheckouts on, the page should show three tabs: All, > Checkouts, and On-site checkouts. >- Confirm that clicking on each tab correctly filters the table, e.g. > the On-site checkouts tab should show only on-site checkouts. >--- > .../prog/en/modules/members/readingrec.tt | 30 +++++++------------ > 1 file changed, 11 insertions(+), 19 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >index 6e4ff3f9e5..3acc84e067 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt >@@ -54,9 +54,9 @@ > <div id="tabs" class="toptabs"> > [% IF Koha.Preference('OnSiteCheckouts') %] > <ul class="nav nav-tabs" role="tablist"> >- <li role="presentation" class="active"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" id="tab_all">All</a></li> >- <li role="presentation"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" id="tab_checkout">Checkouts</a></li> >- <li role="presentation"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" id="tab_onsite_checkout">On-site checkouts</a></li> >+ <li role="presentation" class="active"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" data-tabname="all" id="tab_all">All</a></li> >+ <li role="presentation"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" data-tabname="checkouts" id="tab_checkout">Checkouts</a></li> >+ <li role="presentation"><a href="#readingrec" aria-controls="readingrec" role="tab" data-toggle="tab" id="tab_onsite_checkout" data-tabname="onsite">On-site checkouts</a></li> > </ul> > <div class="tab-content"> > <div id="readingrec" role="tabpanel" class="tab-pane active"> >@@ -162,24 +162,16 @@ > "aaSorting": [[10, 'desc']] > }, columns_settings); > >- // var tabs = $("#tabs").tabs({ >- // activate: function(e, ui) { >- // var active = tabs.tabs("option", "active" ); >- // if ( active == 1 ) { >- // table.fnFilter("standard_checkout", 0); >- // } else if ( active == 2 ) { >- // table.fnFilter("onsite_checkout", 0); >- // } else { // all >- // table.fnFilter('', 0); >- // } >- // } >- // }); >- > $("#tabs a[data-toggle='tab']").on("shown.bs.tab", function (e) { >- console.log("New activated tab", e.target); >- console.log("Previous active tab", e.relatedTarget); >+ active_tab = $(this).data("tabname"); >+ if( active_tab == "checkouts" ){ >+ table.fnFilter("standard_checkout", 0); >+ } else if( active_tab == "onsite" ){ >+ table.fnFilter("onsite_checkout", 0); >+ } else { >+ table.fnFilter('', 0); >+ } > }); >- > }); > </script> > [% END %] >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30456
:
132967
|
132968
|
132977
|
132986