Bugzilla – Attachment 133190 Details for
Bug 29346
Real-time holds queue update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29346: (follow-up) Fix import issue in HoldsQueue
Bug-29346-follow-up-Fix-import-issue-in-HoldsQueue.patch (text/plain), 1.24 KB, created by
Martin Renvoize
on 2022-04-11 16:23:11 UTC
(
hide
)
Description:
Bug 29346: (follow-up) Fix import issue in HoldsQueue
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-04-11 16:23:11 UTC
Size:
1.24 KB
patch
obsolete
>From 3e42fdec36902d34c5b3b89c504385da81d184e3 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 11 Apr 2022 17:06:46 +0100 >Subject: [PATCH] Bug 29346: (follow-up) Fix import issue in HoldsQueue > >For some reason `t/db_dependent/HoldsQueue..t` starts failing for me >without this patch.. using the full module path resolves the issue but >I'd love to understand why/how this creeps in. >--- > C4/HoldsQueue.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 7073760881..5a942f847b 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -349,9 +349,9 @@ sub GetItemsAvailableToFillHoldRequestsForBib { > $sth->execute(@params); > > my $itm = $sth->fetchall_arrayref({}); >- my @items = grep { ! scalar GetTransfers($_->{itemnumber}) } @$itm; >+ my @items = grep { ! scalar C4::Circulation::GetTransfers($_->{itemnumber}) } @$itm; > return [ grep { >- my $rule = GetBranchItemRule($_->{homebranch}, $_->{itype}); >+ my $rule = C4::Circulation::GetBranchItemRule($_->{homebranch}, $_->{itype}); > $_->{holdallowed} = $rule->{holdallowed}; > $_->{hold_fulfillment_policy} = $rule->{hold_fulfillment_policy}; > } @items ]; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29346
:
131088
|
131089
|
131811
|
131812
|
131813
|
131815
|
132078
|
132079
|
132080
|
132081
|
132082
|
132083
|
133183
|
133184
|
133185
|
133186
|
133187
|
133188
|
133189
|
133190
|
133191
|
133205
|
133991
|
133992
|
133993
|
133994
|
133995
|
133996
|
133997
|
133998
|
133999
|
134000
|
134001
|
134010
|
134225
|
134227
|
134309
|
134310
|
134311
|
134312
|
134313
|
134314
|
134315
|
134316
|
134317
|
134318
|
134319
|
134320
|
134321
|
134322
|
134328
|
134329
|
134330
|
134331
|
134332
|
134333
|
134334
|
134335
|
134336
|
134337
|
134338
|
134339
|
134340
|
134341
|
134342
|
134343