From 3b4c69e995d4c2d0838aa5ed5718852d7e772694 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Mon, 4 Apr 2022 19:22:16 +1200 Subject: [PATCH] Bug 30444: Add shibboleth login to self checkout This patch adds a 'Shibboleth' option to the SelfCheckoutByLogin system preference. When 'Shibboleth' is selected the user should be logged straight into the self check module - assuming the AutoSelfCheckAllowed, AutoSelfCheckID and AutoSelfCheckPass system preferences are set. Test plan: 1. Have your Koha setup to do Shibboleth login 2. Set the following system preferences: - AutoSelfCheckAllowed => 'Allow' - AutoSelfCheckId and AutoSelfCheckPass => Set these to a patron with 'circulate' permissions - WebBasedSelfCheck -> 'Enable' - OpacShibOnly -> "Don't allow" 3. Visit the self checkout page /cgi-bin/koha/sco/sco-main.pl and notice a local login page loads 4. Apply patchset, update database and restart services 5. Set the new syspref: - SelfCheckoutByLogin -> 'Shibboleth' 6. Visit the self checkout page and notice you're logged into the sco interface straight away, without the local login page loading Sponsored-by: Catalyst IT --- ..._30444-edit_SelfCheckoutByLogin_syspref.pl | 16 +++++++++++++ installer/data/mysql/mandatory/sysprefs.sql | 2 +- opac/sco/sco-main.pl | 24 +++++++++++++++---- 3 files changed, 37 insertions(+), 5 deletions(-) create mode 100755 installer/data/mysql/atomicupdate/bug_30444-edit_SelfCheckoutByLogin_syspref.pl diff --git a/installer/data/mysql/atomicupdate/bug_30444-edit_SelfCheckoutByLogin_syspref.pl b/installer/data/mysql/atomicupdate/bug_30444-edit_SelfCheckoutByLogin_syspref.pl new file mode 100755 index 00000000000..07619fc880c --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_30444-edit_SelfCheckoutByLogin_syspref.pl @@ -0,0 +1,16 @@ +use Modern::Perl; + +return { + bug_number => "30444", + description => "Edit existing system preference SelfCheckoutByLogin", + up => sub { + my ($args) = @_; + my ($dbh, $out) = @$args{qw(dbh out)}; + + # Update existing values + $dbh->do(q{UPDATE systempreferences SET value = 'cardnumber' WHERE variable = "SelfCheckoutByLogin" AND value = 0}); + $dbh->do(q{UPDATE systempreferences SET value = 'username' WHERE variable = "SelfCheckoutByLogin" AND value = 1}); + + $dbh->do(q{UPDATE systempreferences SET explanation = "Have patrons login into the web-based self checkout system with their username/password, their cardnumber, or using shibboleth" WHERE variable = "SelfCheckoutByLogin"}); + }, +}; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index 34523550c07..8bf4508552f 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -606,7 +606,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('SelfCheckInTimeout','120','','Define the number of seconds before the self check-in module times out.','Integer'), ('SelfCheckInUserCSS','',NULL,'Add CSS to be included in the self check-in module in an embedded