Bugzilla – Attachment 133430 Details for
Bug 29744
Harmonize psgi/plack detection methods
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29744: Remove unnecessary condition in C4::Auth::safe_exit
Bug-29744-Remove-unnecessary-condition-in-C4Authsa.patch (text/plain), 769 bytes, created by
David Cook
on 2022-04-20 05:28:48 UTC
(
hide
)
Description:
Bug 29744: Remove unnecessary condition in C4::Auth::safe_exit
Filename:
MIME Type:
Creator:
David Cook
Created:
2022-04-20 05:28:48 UTC
Size:
769 bytes
patch
obsolete
>From 7bd1c8d68ba3fadb74b7f459dd14584c80614dc1 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Wed, 20 Apr 2022 05:27:32 +0000 >Subject: [PATCH] Bug 29744: Remove unnecessary condition in > C4::Auth::safe_exit > >--- > C4/Auth.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index 6b8718ec3e..03bd4c4d88 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -55,9 +55,9 @@ use Koha::CookieManager; > use vars qw($ldap $cas $caslogout); > our (@ISA, @EXPORT_OK); > >+#NOTE: The utility of keeping the safe_exit function is that it can be easily re-defined in unit tests and plugins > sub safe_exit { >- if (C4::Context::psgi_env) { die 'psgi:exit' } >- else { exit } >+ exit; > } > > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29744
:
132299
|
132975
|
133429
|
133430
|
140689
|
140690
|
140691
|
140692
|
140922