Bugzilla – Attachment 13383 Details for
Bug 5366
Koha does not work right with MariaDB
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5366 - Standing enh req for code changes enabling database agnosticism
Bug-5366---Standing-enh-req-for-code-changes-enabl.patch (text/plain), 2.07 KB, created by
Chris Nighswonger
on 2012-11-12 03:07:20 UTC
(
hide
)
Description:
Bug 5366 - Standing enh req for code changes enabling database agnosticism
Filename:
MIME Type:
Creator:
Chris Nighswonger
Created:
2012-11-12 03:07:20 UTC
Size:
2.07 KB
patch
obsolete
>From 866a8d062d46e65657fd3104448249719bc44355 Mon Sep 17 00:00:00 2001 >From: Chris Nighswonger <cnighswonger@foundations.edu> >Date: Thu, 4 Nov 2010 14:05:29 -0400 >Subject: [PATCH] Bug 5366 - Standing enh req for code changes enabling > database agnosticism >Content-Type: text/plain; charset="utf-8" > >MariaDB apparently will not fudge when one attempts to insert a null value into a >NOT NULL field with no default defined. This probably should have been fixed in >any case, but must be fixed if Koha is to run over MariaDB. > >This patch simple supplies a single blank space as the value passed in on the >initial insert. >--- > C4/Biblio.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 81ccfbb..92a9534 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -3028,7 +3028,7 @@ Internal function to add a biblioitem > sub _koha_add_biblioitem { > my ( $dbh, $biblioitem ) = @_; > my $error; >- >+ my $marcxml = " "; > my ($cn_sort) = GetClassSort( $biblioitem->{'biblioitems.cn_source'}, $biblioitem->{'cn_class'}, $biblioitem->{'cn_item'} ); > my $query = "INSERT INTO biblioitems SET > biblionumber = ?, >@@ -3059,7 +3059,8 @@ sub _koha_add_biblioitem { > cn_item = ?, > cn_suffix = ?, > cn_sort = ?, >- totalissues = ? >+ totalissues = ?, >+ marcxml = ? > "; > my $sth = $dbh->prepare($query); > $sth->execute( >@@ -3070,7 +3071,7 @@ sub _koha_add_biblioitem { > $biblioitem->{'pages'}, $biblioitem->{'bnotes'}, $biblioitem->{'size'}, $biblioitem->{'place'}, > $biblioitem->{'lccn'}, $biblioitem->{'marc'}, $biblioitem->{'url'}, $biblioitem->{'biblioitems.cn_source'}, > $biblioitem->{'cn_class'}, $biblioitem->{'cn_item'}, $biblioitem->{'cn_suffix'}, $cn_sort, >- $biblioitem->{'totalissues'} >+ $biblioitem->{'totalissues'}, $marcxml > ); > my $bibitemnum = $dbh->{'mysql_insertid'}; > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5366
:
13383
|
13384
|
13478
|
13479
|
13480