From 87b8335f3af2c7531fdce4267932220c87dede8d Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 1 Nov 2012 11:21:37 -0400 Subject: [PATCH] Bug 7932 [Revised] Twitter share doesn't work with socialnetworks Content-Type: text/plain; charset="utf-8" The only way I can get this to work consistently is to use Twitter's own code as documented here: https://dev.twitter.com/docs/tweet-button This requires that we use the tweet button generated by Twitter rather than the smaller image we were using before. Using the documented options for generating a custom button produced the same inconsistent behavior this patch attempts to fix. Because of the change of appearance I moved the Twitter button to last in line so that similarly-sized buttons were grouped. I also changed the configuration of the Google+ button to exclude the count, saving some horizontal space. Revision removes explicit declaration of share URL. I think when testing this previously I assumed it was required when in fact the share URL wasn't working because it was a localhost address. Localhost addresses are apparently rejected by Twitter. Testers beware. --- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index 1d0523a..fa1d6c9 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -8,6 +8,7 @@ + [% END %] [% IF ( OpacStarRatings != 'disable' ) %] [% END %] @@ -1215,11 +1216,11 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
Share
Facebook
-
Twitter
LinkedIn
Delicious
Email
-
+
+
[% END %] -- 1.7.9.5