Bugzilla – Attachment 133999 Details for
Bug 29346
Real-time holds queue update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29346: Highlight double enqueue
Bug-29346-Highlight-double-enqueue.patch (text/plain), 1.75 KB, created by
Tomás Cohen Arazi
on 2022-04-26 19:39:34 UTC
(
hide
)
Description:
Bug 29346: Highlight double enqueue
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-04-26 19:39:34 UTC
Size:
1.75 KB
patch
obsolete
>From 836518bac79125a239b69710eb571abd3cfebf85 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 11 Apr 2022 17:20:11 +0100 >Subject: [PATCH] Bug 29346: Highlight double enqueue > >This patch highlights a possible issue with the triggers.. though it may >not actually matter in reality. > >I appear to already see test failures before this patch with a double >enqueue of the rebuild for both AddIssue and AddReturn.. I couldn't spot >what was causing that but whilst digging I did find another case where >it could happen as highlighted here... > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Circulation_holdsqueue.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation_holdsqueue.t b/t/db_dependent/Circulation_holdsqueue.t >index f8a82ffd199..45b5a731d64 100755 >--- a/t/db_dependent/Circulation_holdsqueue.t >+++ b/t/db_dependent/Circulation_holdsqueue.t >@@ -41,16 +41,18 @@ subtest 'AddIssue() and AddReturn() real-time holds queue tests' => sub { > my $item = $builder->build_sample_item({ library => $library->id }); > > t::lib::Mocks::mock_userenv({ branchcode => $library->id }); >+ t::lib::Mocks::mock_preference( 'UpdateTotalIssuesOnCirc', 1 ); > > my $action; > > my $mock = Test::MockModule->new('Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue'); > $mock->mock( 'enqueue', sub { > my ( $self, $args ) = @_; >+ my ($package, $filename, $line) = caller; > is_deeply( > $args->{biblio_ids}, > [ $item->biblionumber ], >- "$action triggers a holds queue update for the related biblio" >+ "$action triggers a holds queue update for the related biblio from $package" > ); > } ); > >-- >2.36.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29346
:
131088
|
131089
|
131811
|
131812
|
131813
|
131815
|
132078
|
132079
|
132080
|
132081
|
132082
|
132083
|
133183
|
133184
|
133185
|
133186
|
133187
|
133188
|
133189
|
133190
|
133191
|
133205
|
133991
|
133992
|
133993
|
133994
|
133995
|
133996
|
133997
|
133998
|
133999
|
134000
|
134001
|
134010
|
134225
|
134227
|
134309
|
134310
|
134311
|
134312
|
134313
|
134314
|
134315
|
134316
|
134317
|
134318
|
134319
|
134320
|
134321
|
134322
|
134328
|
134329
|
134330
|
134331
|
134332
|
134333
|
134334
|
134335
|
134336
|
134337
|
134338
|
134339
|
134340
|
134341
|
134342
|
134343