Bugzilla – Attachment 134005 Details for
Bug 30072
Add more holds hooks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30072: (followup) Fix random failure of Holds_hooks.t
Bug-30072-followup-Fix-random-failure-of-Holdshook.patch (text/plain), 1.25 KB, created by
Fridolin Somers
on 2022-04-27 00:19:10 UTC
(
hide
)
Description:
Bug 30072: (followup) Fix random failure of Holds_hooks.t
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2022-04-27 00:19:10 UTC
Size:
1.25 KB
patch
obsolete
>From 1302e87ed22ded4bdff3808f7400b0f96d872db9 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 26 Apr 2022 14:17:00 -1000 >Subject: [PATCH] Bug 30072: (followup) Fix random failure of Holds_hooks.t > >When building Koha::Holds object, >do not let 'found' random otherwise it may take a valid value indicating >hold is found. > >See other holds unit tests. >--- > t/db_dependent/Koha/Plugins/Holds_hooks.t | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Plugins/Holds_hooks.t b/t/db_dependent/Koha/Plugins/Holds_hooks.t >index 04d19929ca..54171097f3 100755 >--- a/t/db_dependent/Koha/Plugins/Holds_hooks.t >+++ b/t/db_dependent/Koha/Plugins/Holds_hooks.t >@@ -103,7 +103,7 @@ subtest 'Koha::Hold tests' => sub { > { > class => 'Koha::Holds', > value => { >- borrowernumber => $patron->id, >+ borrowernumber => $patron->id, found => undef, > } > } > ); >@@ -118,7 +118,7 @@ subtest 'Koha::Hold tests' => sub { > { > class => 'Koha::Holds', > value => { >- borrowernumber => $patron->id, >+ borrowernumber => $patron->id, found => undef, > } > } > ); >-- >2.35.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30072
:
130517
|
130518
|
130519
|
130522
|
130523
|
130524
|
130621
|
130622
|
130623
|
130624
|
130718
|
130719
|
130720
|
130721
|
130722
|
130723
|
131366
| 134005