From 4ac080e83b82c19e02dfcec63f33a342e91aef2e Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 4 Mar 2022 16:19:35 +0000 Subject: [PATCH] Bug 24001: Fix Card template/rpinter profile creation and edit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=30373 --- C4/Creators/Profile.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Creators/Profile.pm b/C4/Creators/Profile.pm index cd1de4038b..b9759bd6a8 100644 --- a/C4/Creators/Profile.pm +++ b/C4/Creators/Profile.pm @@ -59,7 +59,7 @@ sub new { my $type = ref($invocant) || $invocant; my $self = { printer_name => 'Default Printer', - template_id => '', + template_id => 0, paper_bin => 'Tray 1', offset_horz => 0, offset_vert => 0, -- 2.30.2