From e686ab4549339e8c42afe3a5c954bffde6a22d63 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 16 Dec 2021 12:54:01 +0100
Subject: [PATCH] Bug 29648: Checkout history - normal no sort

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 admin/columns_settings.yml                                | 1 +
 .../prog/en/modules/catalogue/issuehistory.tt             | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index f58b95d8b1..b2c2ba2993 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -484,6 +484,7 @@ modules:
               columnname: subscription_callnumber
 
       checkoutshistory-table:
+        default_display_length: 20
         columns:
             -
               columnname: patron
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
index 53c0121d52..21e4917474 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
@@ -131,16 +131,16 @@
 [% INCLUDE 'columns_settings.inc' %]
     <script id="js">
         $(document).ready(function() {
-            var columns_settings = [% TablesSettings.GetColumns('catalogue', 'detail', 'checkoutshistory-table', 'json') %];
+            var table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'checkoutshistory-table', 'json') %];
             [% UNLESS show_patron_column %]
-            // Remove the patron column definition
-            columns_settings.splice(0,1);
+                // Remove the patron column definition
+                table_settings['columns'].splice(0,1);
             [% END %]
             var table = KohaTable("table_issues", {
                 "sDom": 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>',
                 "aaSorting": [[ 5, "desc" ]],
                 "sPaginationType": "full_numbers"
-            }, columns_settings);
+            }, table_settings);
         });
     </script>
 [% END %]
-- 
2.20.1