Bugzilla – Attachment 134342 Details for
Bug 29346
Real-time holds queue update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29346: Use fully qualified names for C4:Circulation routines in C4::HoldsQueue
Bug-29346-Use-fully-qualified-names-for-C4Circulat.patch (text/plain), 1.54 KB, created by
Nick Clemens
on 2022-04-29 01:03:45 UTC
(
hide
)
Description:
Bug 29346: Use fully qualified names for C4:Circulation routines in C4::HoldsQueue
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2022-04-29 01:03:45 UTC
Size:
1.54 KB
patch
obsolete
>From e95c85e1b018d82398b00e0e82b37d5a10046553 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 29 Apr 2022 00:28:33 +0000 >Subject: [PATCH] Bug 29346: Use fully qualified names for C4:Circulation > routines in C4::HoldsQueue > >I suppose this is similar to circular dependency on other patch > >HoldsQueue uses Circulation uses BatchUpdateBiblioHoldsQueueuse HoldsQueue > >Without this the background job builds the queue, but reports failure: >Holds queue for biblio The Jacobite clans of the Great Glen, 1650-1784 /. An error occurred (Undefined subroutine &C4::HoldsQueue::GetTransfers called at /kohadevbox/koha/C4/HoldsQueue.pm line 351. ) > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > C4/HoldsQueue.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index ae93f66dba..f2eb1ee4b8 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -348,9 +348,9 @@ sub GetItemsAvailableToFillHoldRequestsForBib { > $sth->execute(@params); > > my $itm = $sth->fetchall_arrayref({}); >- my @items = grep { ! scalar GetTransfers($_->{itemnumber}) } @$itm; >+ my @items = grep { ! scalar C4::Circulation::GetTransfers($_->{itemnumber}) } @$itm; > return [ grep { >- my $rule = GetBranchItemRule($_->{homebranch}, $_->{itype}); >+ my $rule = C4::Circulation::GetBranchItemRule($_->{homebranch}, $_->{itype}); > $_->{holdallowed} = $rule->{holdallowed}; > $_->{hold_fulfillment_policy} = $rule->{hold_fulfillment_policy}; > } @items ]; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29346
:
131088
|
131089
|
131811
|
131812
|
131813
|
131815
|
132078
|
132079
|
132080
|
132081
|
132082
|
132083
|
133183
|
133184
|
133185
|
133186
|
133187
|
133188
|
133189
|
133190
|
133191
|
133205
|
133991
|
133992
|
133993
|
133994
|
133995
|
133996
|
133997
|
133998
|
133999
|
134000
|
134001
|
134010
|
134225
|
134227
|
134309
|
134310
|
134311
|
134312
|
134313
|
134314
|
134315
|
134316
|
134317
|
134318
|
134319
|
134320
|
134321
|
134322
|
134328
|
134329
|
134330
|
134331
|
134332
|
134333
|
134334
|
134335
|
134336
|
134337
|
134338
|
134339
|
134340
|
134341
| 134342 |
134343