Bugzilla – Attachment 134352 Details for
Bug 30143
OAI-PMH provider may end up in an eternal loop due to missing sort
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
Bug-30143-OAI-PMH-Fix-SQL-query-used-to-fetch-dele.patch (text/plain), 1.14 KB, created by
Marcel de Rooy
on 2022-04-29 08:58:30 UTC
(
hide
)
Description:
Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted records
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-04-29 08:58:30 UTC
Size:
1.14 KB
patch
obsolete
>From 96352ae91e7388054db20987d88ff55d84f8a944 Mon Sep 17 00:00:00 2001 >From: Ere Maijala <ere.maijala@helsinki.fi> >Date: Mon, 21 Feb 2022 16:07:00 +0200 >Subject: [PATCH] Bug 30143: OAI-PMH: Fix SQL query used to fetch deleted > records >MIME-Version: 1.0 >Content-Type: text/plain; charset=utf-8 >Content-Transfer-Encoding: 8bit >Content-Type: text/plain; charset=utf-8 > >The query was missing the "ORDER BY" and "LIMIT" clauses, which could make retrieve a wrong set of records. > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/OAI/Server/ListBase.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/OAI/Server/ListBase.pm b/Koha/OAI/Server/ListBase.pm >index 4f1092d146..283f1b3334 100644 >--- a/Koha/OAI/Server/ListBase.pm >+++ b/Koha/OAI/Server/ListBase.pm >@@ -116,7 +116,7 @@ sub GetRecords { > $sql = " > SELECT biblionumber > FROM $table main >- WHERE $where >+ WHERE $where $order_limit > "; > > $ts_sql = "SELECT max(timestamp) FROM $table WHERE biblionumber = ?"; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30143
:
130961
|
133703
| 134352