From 27c4c5a7c0cbc228128717465c3ad439dadc5d83 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 5 May 2022 11:13:08 +0000 Subject: [PATCH] Bug 30689: Incorrect Babeltheque setting can cause console warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch adds an additional system preference check to the part of the OPAC bibliographic detail template which conditionally loads Babelthèque JavaScript. The script tag should not be output if there is no Babeltheque_url_js setting to use. To test, apply the patch and search for "Babeltheque" in system preferences. - Set "Babeltheque" to "Do" include information. - Enter a path in the "Babeltheque_url_js" preference, e.g. "https://www.example.com/example.js" It doesn't have to be a valid Babeltheque URL. - In the OPAC, view the bibliographic detail page for any title. If you used a dummy URL for the js preference you should see an error in the console about the file not being found. This confirms that the template logic is working. If you used a working Babeltheque URL then the corresponding content should load. - Return to system preferences and remove the URL from the "Babeltheque_url_js" preference. - Return to the bibliographic detail page in the OPAC and confirm that there is no warning in the console about "'src' attribute of [% END %] - [% IF ( Babeltheque ) %] + [% IF ( Babeltheque && Babeltheque_url_js ) %] [% END %] -- 2.30.2