Bugzilla – Attachment 134817 Details for
Bug 30710
Background tasks can be called multiple times on batch item deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30710: Regression tests
Bug-30710-Regression-tests.patch (text/plain), 2.81 KB, created by
Tomás Cohen Arazi
on 2022-05-10 14:46:14 UTC
(
hide
)
Description:
Bug 30710: Regression tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-05-10 14:46:14 UTC
Size:
2.81 KB
patch
obsolete
>From 04138420e5f5d334311647850e78631d8fd8c0fc Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 10 May 2022 11:43:46 -0300 >Subject: [PATCH] Bug 30710: Regression tests > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../Koha/BackgroundJobs/BatchDeleteItem.t | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100755 t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t > >diff --git a/t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t b/t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t >new file mode 100755 >index 0000000000..a3779f0b1f >--- /dev/null >+++ b/t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t >@@ -0,0 +1,73 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 1; >+use Test::MockModule; >+ >+use JSON qw( encode_json ); >+ >+use Koha::Database; >+use Koha::BackgroundJob::BatchDeleteItem; >+ >+use t::lib::TestBuilder; >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+subtest "process() tests" => sub { >+ >+ plan tests => 1; >+ >+ $schema->storage->txn_begin; >+ >+ my $biblio = $builder->build_sample_biblio; >+ my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->id }); >+ my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->id }); >+ >+ my $counter = 0; >+ >+ my $mock_holds_queue_job = Test::MockModule->new('Koha::BackgroundJob::BatchUpdateBiblioHoldsQueue'); >+ $mock_holds_queue_job->mock( 'enqueue', sub { >+ $counter++; >+ }); >+ >+ my $job = Koha::BackgroundJob::BatchDeleteItem->new( >+ { >+ status => 'new', >+ size => 2, >+ borrowernumber => undef, >+ type => 'batch_biblio_record_modification', >+ data => encode_json { >+ record_ids => [ $item_1->id, $item_2->id ], >+ delete_biblios => 1, >+ } >+ } >+ ); >+ >+ $job->process( >+ { >+ record_ids => [ $item_1->id, $item_2->id ], >+ delete_biblios => 1, >+ } >+ ); >+ >+ is( $counter, 1, 'Holds queue update is enqueued only once' ); >+ >+ $schema->storage->txn_rollback; >+}; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30710
:
134742
|
134743
| 134817 |
134818
|
134819