From 75307c33142407166f721761f232d2e08e78d10c Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Fri, 13 May 2022 15:10:24 +0000 Subject: [PATCH] Bug 30747: Make column settings work for otherholdings table To test: 1. Turn on SeparateHoldings and find a record that has some items at different home libraries. 2. Look at the Other holdings(x) tab. Notice there is no Columns tool (gear icon). 3. Go to Table Settings, try hiding columns from the otherholdings table. You cannot. 4. Apply patch. 5. Now under the Other holdings(x) tab you should see the Columns button, it should work. 6. Go back to Table settings and try hiding columns, it should work. 7. Now try uploading an item level cover image, make sure all columns are still properly hidden and the Columns tool works 8 Try steps 6 & 7 but with the regular holdings table. Confirm that all colums can properly hide. --- koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 054d3b97b7..b3edea5078 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -1372,7 +1372,7 @@ Note that permanent location is a code, and location may be an authval. for (var i in ids) { var id = ids[i]; if ( !has_images[i] ) { // remove the cover_image column - table_settings.splice(1,1); + table_settings[i].columns.splice(1,1); } var dt_parameters = { 'sDom': 't', -- 2.30.2