Bugzilla – Attachment 135092 Details for
Bug 24010
Number of issues to display to staff accepts non-integer values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24010: DB Changes
Bug-24010-DB-Changes.patch (text/plain), 2.78 KB, created by
Jonathan Druart
on 2022-05-18 07:51:09 UTC
(
hide
)
Description:
Bug 24010: DB Changes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-05-18 07:51:09 UTC
Size:
2.78 KB
patch
obsolete
>From 823805661c675db8e1bf793a45b79985226c1f2b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 22 Nov 2019 12:33:41 +0100 >Subject: [PATCH] Bug 24010: DB Changes > >Amended-patch: adjusted to new atomic update format >--- > .../data/mysql/atomicupdate/bug_24010.pl | 30 +++++++++++++++++++ > installer/data/mysql/kohastructure.sql | 4 +-- > 2 files changed, 32 insertions(+), 2 deletions(-) > create mode 100644 installer/data/mysql/atomicupdate/bug_24010.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_24010.pl b/installer/data/mysql/atomicupdate/bug_24010.pl >new file mode 100644 >index 00000000000..d0bbe10eb1f >--- /dev/null >+++ b/installer/data/mysql/atomicupdate/bug_24010.pl >@@ -0,0 +1,30 @@ >+use Modern::Perl; >+ >+return { >+ bug_number => "24010", >+ description => "Make subscription.staffdisplaycount and opacdisplaycount integer columns", >+ up => sub { >+ my ($args) = @_; >+ my ($dbh, $out) = @$args{qw(dbh out)}; >+ >+ $dbh->do(q{ >+ UPDATE subscription >+ SET staffdisplaycount = NULL >+ WHERE staffdisplaycount = "" >+ }); >+ $dbh->do(q{ >+ ALTER TABLE subscription >+ MODIFY COLUMN staffdisplaycount INT(11) NULL DEFAULT NULL >+ }); >+ >+ $dbh->do(q{ >+ UPDATE subscription >+ SET opacdisplaycount = NULL >+ WHERE opacdisplaycount = "" >+ }); >+ $dbh->do(q{ >+ ALTER TABLE subscription >+ MODIFY COLUMN opacdisplaycount INT(11) NULL DEFAULT NULL >+ }); >+ }, >+}; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index 852d4488040..f305e9c8dc1 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -4869,8 +4869,8 @@ CREATE TABLE `subscription` ( > `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '' COMMENT 'default branches (items.homebranch)', > `lastbranch` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, > `serialsadditems` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'does receiving this serial create an item record', >- `staffdisplaycount` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'how many issues to show to the staff', >- `opacdisplaycount` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL COMMENT 'how many issues to show to the public', >+ `staffdisplaycount` INT(11) NULL DEFAULT NULL, -- how many issues to show to the staff >+ `opacdisplaycount` INT(11) NULL DEFAULT NULL, -- how many issues to show to the public > `graceperiod` int(11) NOT NULL DEFAULT 0 COMMENT 'grace period in days', > `enddate` date DEFAULT NULL COMMENT 'subscription end date', > `closed` tinyint(1) NOT NULL DEFAULT 0 COMMENT 'yes / no if the subscription is closed', >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24010
:
95610
|
95717
|
95718
|
95847
|
95935
|
134985
|
134986
|
135092
|
136538
|
136539
|
137060
|
137062
|
137175