From 5ead56f6d43a43abffdbd6eef73243cd664d16c9 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 18 Mar 2022 15:03:30 +0000 Subject: [PATCH] Bug 30009: Do not set MARCNOTES to empty list in list context Content-Type: text/plain; charset=utf-8 AMENDED: We should not pass an empty list here, but just undef in order to prevent creating a shift of elements in the hash. To test: 1 - Find or create an invalid marc record 2 - View in staff client 3 - Note tab Descriptions(1) has no content 4 - Apply patch, reload 5 - No empty tab Signed-off-by: David Nind Signed-off-by: Marcel de Rooy --- catalogue/detail.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 9687f3b01b..29b6167f61 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -464,7 +464,7 @@ $template->param( ); $template->param( - MARCNOTES => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : (), + MARCNOTES => $marc_record ? $biblio->get_marc_notes({ marcflavour => $marcflavour }) : undef, itemdata_ccode => $itemfields{ccode}, itemdata_enumchron => $itemfields{enumchron}, itemdata_uri => $itemfields{uri}, -- 2.20.1