From 0e304aeff8a1ecd1a1a2ed74c643353343a09ff5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 10 Jan 2022 10:15:35 +0100 Subject: [PATCH] Bug 29828: Prevent additional content to be created without default Content-Type: text/plain; charset=utf-8 When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy --- .../prog/en/modules/tools/additional-contents.tt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt index 62f8c5febb..5b1ea8a746 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt @@ -574,6 +574,18 @@ alert(_("Please specify a title for 'Default'")); return false; } + else { + [% UNLESS wysiwyg %] + let content = $('#content_default').siblings(".CodeMirror")[0].CodeMirror.getValue(); + [% ELSE %] + let content = tinyMCE.get('content_default').getContent(); + [% END %] + + if ( ! content.length > 0 ) { + alert(__("Please specify a content for 'Default'")); + return false; + } + } form.submit(); } -- 2.20.1