Bugzilla – Attachment 135224 Details for
Bug 30755
auto_too_soon should not be counted as an error in autorenewals
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30755: Remove auto_too_soon from error count
Bug-30755-Remove-autotoosoon-from-error-count.patch (text/plain), 2.05 KB, created by
Martin Renvoize
on 2022-05-20 07:09:35 UTC
(
hide
)
Description:
Bug 30755: Remove auto_too_soon from error count
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-05-20 07:09:35 UTC
Size:
2.05 KB
patch
obsolete
>From e26cab37911b3a3e1f15d5145908c9bfdbde37bc Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 20 May 2022 08:08:28 +0100 >Subject: [PATCH] Bug 30755: Remove auto_too_soon from error count > >This patch prevents auto_too_soon errors being counted towards auto >renew errors. >--- > misc/cronjobs/automatic_renewals.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/misc/cronjobs/automatic_renewals.pl b/misc/cronjobs/automatic_renewals.pl >index 1af18c70f5..d3157d1f1d 100755 >--- a/misc/cronjobs/automatic_renewals.pl >+++ b/misc/cronjobs/automatic_renewals.pl >@@ -202,12 +202,12 @@ while ( my $auto_renew = $auto_renews->next ) { > # cache this one to process after we've run through all of the items. > if ($digest_per_branch) { > $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{success}++ if $error eq 'auto_renew'; >- $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew'; >+ $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew' || $error eq 'auto_too_soon'; > push @{$renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{issues}}, $auto_renew->itemnumber; > $renew_digest->{ $auto_renew->branchcode }->{ $auto_renew->borrowernumber }->{updated} = 1 if $updated && $error ne 'auto_too_soon'; > } else { > $renew_digest->{ $auto_renew->borrowernumber }->{success} ++ if $error eq 'auto_renew'; >- $renew_digest->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew'; >+ $renew_digest->{ $auto_renew->borrowernumber }->{error}++ unless $error eq 'auto_renew' || $error eq 'auto_too_soon'; > $renew_digest->{ $auto_renew->borrowernumber }->{updated} = 1 if $updated && $error ne 'auto_too_soon'; > push @{$renew_digest->{ $auto_renew->borrowernumber }->{issues}}, $auto_renew->itemnumber; > } >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30755
:
135224
|
140078
|
140079
|
140099
|
140100