From 11e95cad99bd13647da85170e79ea5e4364fb5bc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@iki.fi>
Date: Sat, 21 May 2022 19:23:32 +0000
Subject: [PATCH] Bug 30828: remove useless type parameter in placerequest.pl
To test:
1) Grep for placerequest.pl in the source code and check that
request.tt is the only place where the type parameter is passed.
---
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 --
reserve/placerequest.pl | 3 +--
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index 59f215ebd2..2e82d6fc77 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -441,8 +441,6 @@
<form action="placerequest.pl" method="post" name="form" id="hold-request-form">
<input type="hidden" name="borrowernumber" value="[% patron.borrowernumber | html %]" />
- <input type="hidden" name="type" value="str8" />
-
[% FOREACH biblionumber IN biblionumbers %]
<input type="hidden" name="biblionumber" value="[% biblionumber | html %]"/>
[% END %]
diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
index 0a8d6dd64e..7c8e454184 100755
--- a/reserve/placerequest.pl
+++ b/reserve/placerequest.pl
@@ -42,7 +42,6 @@ my $notes = $input->param('notes');
my $branch = $input->param('pickup');
my $startdate = $input->param('reserve_date') || '';
my @rank = $input->multi_param('rank-request');
-my $type = $input->param('type');
my $title = $input->param('title');
my $checkitem = $input->param('checkitem');
my $expirationdate = $input->param('expiration_date');
@@ -66,7 +65,7 @@ foreach my $bibnum (@biblionumbers) {
my $found;
-if ( $type eq 'str8' && $patron ) {
+if ( $patron ) {
foreach my $biblionumber ( keys %bibinfos ) {
--
2.30.2