Bugzilla – Attachment 135469 Details for
Bug 30806
Use patron-title.inc in member-flags template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30806: Migrate to patron-title in member-flags
Bug-30806-Migrate-to-patron-title-in-member-flags.patch (text/plain), 2.38 KB, created by
Jonathan Druart
on 2022-05-31 07:24:28 UTC
(
hide
)
Description:
Bug 30806: Migrate to patron-title in member-flags
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2022-05-31 07:24:28 UTC
Size:
2.38 KB
patch
obsolete
>From 20fbfb41a2ba96059aad1b402a2a76b8ae8a2e78 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 19 May 2022 12:34:01 +0100 >Subject: [PATCH] Bug 30806: Migrate to patron-title in member-flags > >This patch updates the member-flags template to use the patron-title.inc >include wherever patron names are referenced. > >Test plan >1) Navigate to a patron and click through to edit their permissions >2) Note how the patron name displays in the title, breadcrump and > headings >3) Apply the patch and reload the page >4) Confirm the patron name still appears in each location and is > consistently formatted and linked as you would expect > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../intranet-tmpl/prog/en/modules/members/member-flags.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >index 800173a26bb..b64a0bd32a4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt >@@ -5,7 +5,7 @@ > [% PROCESS 'permissions.inc' %] > [% INCLUDE 'doc-head-open.inc' %] > <title> >- Set permissions for [% patron.surname | html %], [% patron.firstname | html %] › Patrons › Koha >+ Set permissions for [% INCLUDE 'patron-title.inc' no_html = 1 %] › Patrons › Koha > </title> > [% INCLUDE 'doc-head-close.inc' %] > </head> >@@ -24,7 +24,7 @@ > </li> > <li> > <a href="#" aria-current="page"> >- Set permissions for [% patron.surname | html %], [% patron.firstname | html %] >+ Set permissions for [% INCLUDE 'patron-title.inc' %] > </a> > </li> > </ol> >@@ -41,7 +41,7 @@ > <input type="hidden" name="csrf_token" value="[% csrf_token | html %]" /> > <input type="hidden" name="member" id="borrowernumber" value="[% patron.borrowernumber | html %]" /> > <input type="hidden" name="newflags" value="1" /> >- <h1>Set permissions for [% patron.surname | html %], [% patron.firstname | html %]</h1> >+ <h1>Set permissions for [% INCLUDE 'patron-title.inc' no_html = 1 %]</h1> > > <div id="permissionstree"> > <div id="permissions_toolbar" class="btn-toolbar"> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30806
:
135200
|
135284
| 135469