From eaf6ee58738f41679bc407b45da5aa08424d9315 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 12 May 2022 16:25:05 +0000 Subject: [PATCH] Bug 26377: Clearly label parts of subscription-add.pl that relate to optional item records This patch modifies the form for adding a new subscription so that the collection and item type fields are shown only when the subscription is configured to create an item when receiving. To test, apply the patch and go to Serials -> New subscription. - When the page first loads, the "Do not create an item record when receiving this serial" radio button should be selected. - Under the "Location" field there should be no item type or collection field. - Select the "Create an item when receiving this serial" radio button. - The item type and collection fields should appear. - Test that the values are correctly saved when you add or edit a subscription. - If you edit a subscription which had item type and collection defined, and you switch to "Do not create an item..." the record should save with empty values for those fields. - Confirm that existing subscriptions open with the correct settings applied: Only records with "Create an item..." checked should open with the item type and collection fields displayed. Signed-off-by: David Nind Signed-off-by: Jonathan Druart --- .../en/modules/serials/subscription-add.tt | 4 ++-- .../intranet-tmpl/prog/js/subscription-add.js | 20 +++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt index 53760cf4fbd..c22a621ee76 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt @@ -199,7 +199,7 @@ fieldset.rows table { clear: none; margin: 0; } [% END %] -
  • +
  • -
  • +