Bugzilla – Attachment 135534 Details for
Bug 30876
recalls/recalls_to_pull.pl introduces an incorrect use of ->search in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30876: Fix wrong call to ->search in list context
Bug-30876-Fix-wrong-call-to--search-in-list-contex.patch (text/plain), 1.09 KB, created by
Tomás Cohen Arazi
on 2022-06-01 11:22:19 UTC
(
hide
)
Description:
Bug 30876: Fix wrong call to ->search in list context
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-06-01 11:22:19 UTC
Size:
1.09 KB
patch
obsolete
>From 4a30403723a44bb21b88e0caa7cbb1675a32d6ab Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 1 Jun 2022 08:16:00 -0300 >Subject: [PATCH] Bug 30876: Fix wrong call to ->search in list context > >The code is clearly incorrect as ->search no longer returns a list when >called in list context. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > recalls/recalls_to_pull.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/recalls/recalls_to_pull.pl b/recalls/recalls_to_pull.pl >index 40d7318067..e2f7d0e15a 100755 >--- a/recalls/recalls_to_pull.pl >+++ b/recalls/recalls_to_pull.pl >@@ -71,7 +71,7 @@ if ( $op eq 'list' ) { > my @locations; > my @libraries; > >- my @items = Koha::Items->search({ biblio_id => $recall->biblio_id }); >+ my @items = Koha::Items->search({ biblio_id => $recall->biblio_id })->as_list; > foreach my $item ( @items ) { > if ( $item->can_be_waiting_recall and !$item->checkout ) { > # if item can be pulled to fulfill recall, collect item data >-- >2.36.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30876
:
135534
|
135535
|
135536
|
135546
|
135547