From c8433574692924caa7c76e53cba7a67c2d09202b Mon Sep 17 00:00:00 2001 From: Janusz Kaczmarek Date: Sun, 5 Jun 2022 18:10:59 +0200 Subject: [PATCH] Bug 30904 - (bug 24387 follow-up) Modifying library in news (additional contents) causes inconsistencies Modifying an existing element of additional content (News) by changing the library causes a duplication of the entry on the Additional contents (News) list. A subsequent attempt of deleting one of the entries results in deleting both of them. This is due to the fact that after the unwanted duplication all the entries share the same additional_contents.code. Test plan ========= 1. Create a piece of news under Tools > News. 2. After having saved it make a modification by changing the library. It should result in two rows in the table. 3. Delete one of the lines with Delete button. Both lines will disappear. 4. Apply the patch. 5. Repeat the steps 1 and 2. Only the one (the modified) entry should be present in the table. --- tools/additional-contents.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/additional-contents.pl b/tools/additional-contents.pl index cead55e9a1..a0ffba1cba 100755 --- a/tools/additional-contents.pl +++ b/tools/additional-contents.pl @@ -100,7 +100,6 @@ elsif ( $op eq 'add_validate' ) { { category => $category, code => $code, - branchcode => $branchcode, lang => $lang, } ); -- 2.30.2