From 3fdda0f62863998cc7ee5e3a2b88cae8d2f755f0 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Wed, 15 Jun 2022 11:10:35 +0000
Subject: [PATCH] Bug 25560: (QA follow-up) Add boolean to schema for
updatenotforloan and update syspref
This patch adds boolean definition to schema and adds some verbosity to the syspref
to make it clear that itemtypes must be set to update
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
Koha/Schema/Result/Itemtype.pm | 1 +
.../prog/en/modules/admin/preferences/circulation.pref | 8 ++++----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Koha/Schema/Result/Itemtype.pm b/Koha/Schema/Result/Itemtype.pm
index db8b6f37c6..a8b05f6782 100644
--- a/Koha/Schema/Result/Itemtype.pm
+++ b/Koha/Schema/Result/Itemtype.pm
@@ -348,6 +348,7 @@ __PACKAGE__->add_columns(
'+rentalcharge_hourly_calendar' => { is_boolean => 1 },
'+rentalcharge_daily_calendar' => { is_boolean => 1 },
'+automatic_checkin' => { is_boolean => 1 },
+ '+updatenotforloan' => { is_boolean => 1 },
);
# Use the ItemtypeLocalization view to create the join on localization
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index ac20ced2de..3042a7643d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -636,10 +636,10 @@ Circulation:
type: textarea
syntax: text/x-yaml
class: code
- - This is a list of value pairs. When an item is checked in, if the not for loan value on the left matches the items not for loan value
- - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan."
- - Each pair of values should be on a separate line.
- - Enable itemtypes to be updated upon checkin on the item type page (Administration > Item types)
+ - "NOTE: Only itemtypes marked to 'Update note for loan status on check-in' on the item type administration page (Administration > Item types) will be affected.</br>"
+ - This is a list of value pairs. Each pair of values should be on a separate line.</br>
+ - When an item is checked in, if the not for loan value on the left matches the items not for loan value
+ - "it will be updated to the right-hand value. For example, '-1: 0' will cause an item that was set to 'Ordered' to now be available for loan.</br>"
-
- pref: CumulativeRestrictionPeriods
choices:
--
2.30.2