Bugzilla – Attachment 136154 Details for
Bug 30234
Serial local covers don't appear in the staff interface for other libraries with SeparateHoldings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30234: Fix local cover image display for other holdings
Bug-30234-Fix-local-cover-image-display-for-other-.patch (text/plain), 1.89 KB, created by
David Nind
on 2022-06-16 12:10:42 UTC
(
hide
)
Description:
Bug 30234: Fix local cover image display for other holdings
Filename:
MIME Type:
Creator:
David Nind
Created:
2022-06-16 12:10:42 UTC
Size:
1.89 KB
patch
obsolete
>From 47006cf16899d8b3efbcb81947f8d0ff7a5264f0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 7 Mar 2022 11:30:35 +0100 >Subject: [PATCH] Bug 30234: Fix local cover image display for other holdings > >Bug 26145 added the ability to add local cover images to items. >If SeparateHoldings is set, items from other libraries are displayed in >a separate tab, and not considered as visible. We have a JS test to >assume that images not shown are not present, this only apply for the >images for the bibliographic record, as they can come from different >sources. > >Test plan: >Turn on LocalCoverImages and SeparateHoldings >Create a record with different items coming from different libraries >Attach images to items and to the biblio >Notice that with this patch you can see the images from the "Other >holdings" tab > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 905fd07bd3..40c7615ac2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1151,7 +1151,8 @@ Note that permanent location is a code, and location may be an authval. > }); > } > >- if( $(coverSlide).find(".cover-image:visible").length < 1 ){ >+ if( $(coverSlide).attr('id') == 'biblio-cover-slider' // Hide if not visible, but only for the biblio images. Images for items are only local cover images >+ && $(coverSlide).find(".cover-image:visible").length < 1 ){ > $(coverSlide).remove(); > } else { > $(coverSlide).addClass("cover-slides"); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30234
:
131397
|
131398
|
131399
|
131400
|
131401
|
131402
|
131418
|
131419
|
131420
|
131430
|
136142
|
136154
|
136324