From 8f0f92ea654522c930307ff540d994c0219f746e Mon Sep 17 00:00:00 2001
From: Petro Vashchuk <stalkernoid@gmail.com>
Date: Mon, 20 Jun 2022 17:08:32 +0300
Subject: [PATCH] Bug 30997: Fix "CGI::param called in list context" warning in
 detail.pl

CGI param found1 should be explicitly scalar,
or else error log gets flooded with this warning:

CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622

This patch fixes it by working with it in a scalar context.
The functionality still remains the same but warning doesn't flood
error log.

To reproduce:
1. Open any biblio (details.pl) page.
2. Check the error log and find the upper mentioned warning,
check the timestamp to ensure that it was added when you loaded the page.
3. Apply the patch.
4. Load the page again, ensure that the same warning doesn't get added
to the log file again.

Signed-off-by: David Nind <david@davidnind.com>
---
 catalogue/detail.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/catalogue/detail.pl b/catalogue/detail.pl
index e4d84aa0ea..3bf6255037 100755
--- a/catalogue/detail.pl
+++ b/catalogue/detail.pl
@@ -619,7 +619,7 @@ if ( C4::Context->preference('UseCourseReserves') ) {
     $template->param( course_reserves => $course_reserves );
 }
 
-$template->param(found1 => $query->param('found1') );
+$template->param(found1 => scalar $query->param('found1') );
 
 $template->param(biblio => $biblio);
 
-- 
2.30.2