From 55df6d53e96549a7b72dbafc993c08d2590b6b43 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Wed, 1 Jun 2022 18:36:44 +0000 Subject: [PATCH] Bug 29325: Call progress callback one last time to confirm comppletion Previously after finishing the loop we were still in a transaction that never completed - we should report progress when done one final time to commit the last records To test: 1 - Stage a file with > 100 records 2 - Commit file 3 - Confirm batch is imported and no records left as staged Signed-off-by: Nick Clemens --- C4/ImportBatch.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/ImportBatch.pm b/C4/ImportBatch.pm index d8717e1b44..222bf74b27 100644 --- a/C4/ImportBatch.pm +++ b/C4/ImportBatch.pm @@ -708,6 +708,7 @@ sub BatchCommitRecords { SetImportRecordStatus($rowref->{'import_record_id'}, 'ignored'); } } + &$progress_callback($rec_num, $schema); # Make sure to commit the final chunk that didn't hit the commit threshhold $sth->finish(); SetImportBatchStatus($batch_id, 'imported'); return ($num_added, $num_updated, $num_items_added, $num_items_replaced, $num_items_errored, $num_ignored); -- 2.30.2