From 101f2ad99aa8a801d60a3a02d2eae8d6ec9c304a Mon Sep 17 00:00:00 2001 From: Johanna Raisa Date: Tue, 14 Jun 2022 09:30:16 +0300 Subject: [PATCH] Bug 31007: Fix CheckMandatorySubfields with select fields for supplement issue The select field validation fails for supplemental issues in serials-edit.tt. Test plan inspired from Bug 29496 : Test plan: 0- Be sure to be in a version of koha where the patch that introduces the bug is present (it is present in master since Jul 8 2021 (it is present in 21.06.00.046) and will be pushed in 21.11.00) 1- Create (or find) a subscription for a biblio record and select the option "Create an item record when receiving this serial" 2- Be sure to have at least one mandatory subfield that is filed with a select input in the framework used by the biblio record. (ex: 995$b, 995$c or 995$e in unimarc; 952$a, 952$b or 952$c in marc21) 3- From the subscription-detail page click on "Receive" 4- Change the status to "Arrived" and fill the item form that appears. 5- Click on "Click to add item" below "Supplemental issue" and fill the item form that appears. 6- Click on "Save" 7- Check that an error box appear with the message " Form not submitted because of the following problem(s) 1 mandatory fields empty (highlighted)" (the number can be different according to the number of concerned subfields) 8- Apply the patch 9- Repeat step 3 to 6 10- Check that no error appear and that your item has been created https://bugs.koha-community.org/show_bug.cgi?id=31007 Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt index d1b93145f4..881c857b2a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt @@ -399,7 +399,7 @@ $(document).ready(function() { [% END %] [% IF ( iteminformatio.marc_value.type == 'select' ) %] - [% FOREACH value IN iteminformatio.marc_value.values %] [% IF ( value == iteminformatio.marc_value.default ) %] -- 2.35.3