From 4cddf9780c2ee4814040f1d698a33909e36e1e41 Mon Sep 17 00:00:00 2001
From: Michal Urban <michalurban177@gmail.com>
Date: Tue, 21 Jun 2022 05:52:58 -0400
Subject: [PATCH] Bug 10086: No way to go back to the basket on uncertain
 prices page

Fixed the edit button placement to the right-most column and fixed the
the displayed information in the order column from calling non-existent
variables based on the item.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)
---
 .../prog/en/modules/acqui/uncertainprice.tt            | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
index 194d837b10..2c4af03ef1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
@@ -101,12 +101,12 @@
         <thead>
 	    <tr>
             <th>Basket</th>
-           <th>[% tp('noun', 'Order') | html %]</th>
-            <th>Edit</th>
+            <th>[% tp('noun', 'Order') | html %]</th>
             <th>By</th>
             <th>Uncertain</th>
             <th>Price</th>
             <th>Quantity</th>
+            <th>Edit</th>
 	    </tr>
         </thead>
         <tbody>
@@ -127,9 +127,6 @@
             [% IF ( uncertainpriceorder.isbn ) %]<br />[% uncertainpriceorder.isbn | html %][% END %]
             <br />
         </td>
-        <td class="actions">
-            <a href="/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=[% uncertainpriceorder.ordernumber %]&amp;booksellerid=[% booksellerid %]&amp;basketno=[% uncertainpriceorder.basketno %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
-        </td>
         <td>
             [% uncertainpriceorder.firstname | html %] [% uncertainpriceorder.surname | html %]
         </td>
@@ -147,6 +144,9 @@
             <input class="check_uncertain" data-ordernumber="[% uncertainpriceorder.ordernumber | html %]" type="text" size="10" name="qty[% uncertainpriceorder.ordernumber | html %]" value="[% uncertainpriceorder.quantity | html %]" />
         [% END %]
 	    </td>
+        <td class="actions">
+            <a href="/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=[% uncertainpriceorder.ordernumber %]&amp;booksellerid=[% booksellerid %]&amp;basketno=[% uncertainpriceorder.basketno %]" class="btn btn-default btn-xs"><i class="fa fa-pencil"></i> Edit</a>
+        </td>
 	    </tr>
 	    [% END %]
     </tbody>
-- 
2.30.2