Bugzilla – Attachment 136669 Details for
Bug 30865
Koha::Biblio->get_components_query should double quote Host-item search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30865: Double-quote Host-item in Koha::Biblio->get_components_query
Bug-30865-Double-quote-Host-item-in-KohaBiblio-get.patch (text/plain), 2.44 KB, created by
Martin Renvoize
on 2022-06-28 06:56:17 UTC
(
hide
)
Description:
Bug 30865: Double-quote Host-item in Koha::Biblio->get_components_query
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-06-28 06:56:17 UTC
Size:
2.44 KB
patch
obsolete
>From a1659f97776e47e779f68b9a844dca623d3004af Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 30 May 2022 03:31:44 +0000 >Subject: [PATCH] Bug 30865: Double-quote Host-item in > Koha::Biblio->get_components_query > >This patch adds double quotes around the term qualified by "Host-item" >in Koha::Biblio->get_components_query(). > >Without them, reserved charactrs like "=" will cause syntax errors like >"CCL parsing error (10014) Unknown qualifier ZOOM for query: > Host-item=(MyTitle = Mysubtitle) > at /usr/share/koha/lib/C4/Search.pm line 245." > >Test plan: >0) Don't apply the patch >1) Create biblio with title and subtitle like (MyTitle : MySubtitle) >2) Note the warning "There was an error searching for analytic records, > please see the logs for details." on the detail page >3) Apply the patch >4) koha-plack --restart kohadev >5) Refresh the detail page >6) Note that the warning message is gone >7) prove t/db_dependent/Koha/Biblio.t > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/Biblio.pm | 2 +- > t/db_dependent/Koha/Biblio.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm >index ea0c9d9f84..0a3c42a97e 100644 >--- a/Koha/Biblio.pm >+++ b/Koha/Biblio.pm >@@ -598,7 +598,7 @@ sub get_components_query { > my $cleaned_title = $marc->subfield('245', "a"); > $cleaned_title =~ tr|/||; > $cleaned_title = $builder->clean_search_term($cleaned_title); >- $searchstr = "Host-item:($cleaned_title)"; >+ $searchstr = qq#Host-item:("$cleaned_title")#; > } > my ($error, $query_str) = $builder->build_query_compat( undef, [$searchstr], undef, undef, [$sort], 0 ); > if( $error ){ >diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t >index 890d4e9b90..d9a3544792 100755 >--- a/t/db_dependent/Koha/Biblio.t >+++ b/t/db_dependent/Koha/Biblio.t >@@ -572,7 +572,7 @@ subtest 'get_components_query' => sub { > t::lib::Mocks::mock_preference( 'ComponentSortField', 'author' ); > t::lib::Mocks::mock_preference( 'ComponentSortOrder', 'za' ); > my ( $comp_q, $comp_s ) = $biblio->get_components_query; >- is($comp_q, "Host-item:(Some boring read)",, "UseControlNumber disabled"); >+ is($comp_q, 'Host-item:("Some boring read")', "UseControlNumber disabled"); > is($comp_s, "author_za", "UseControlNumber disabled sort is correct"); > > t::lib::Mocks::mock_preference( 'UseControlNumber', '1' ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30865
:
135445
| 136669